Implement sound VV #4966
Merged
Implement sound VV #4966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No params yet because I'm lazy but paths and collections work.
|
vv if rust enum existed 😭 |
deltanedas
reviewed
Mar 16, 2024
| if (typeof(SoundSpecifier).IsAssignableFrom(type)) | ||
| { | ||
| var control = new VVPropEditorSoundSpecifier(); | ||
| IoCManager.InjectDependencies(control); |
There was a problem hiding this comment.
wouldnt it be better to have this in the constructor of the control
There was a problem hiding this comment.
Too late other code already code it.
PJB3005
reviewed
Mar 16, 2024
Robust.Client/ViewVariables/Editors/VVPropEditorSoundSpecifier.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No params yet because I'm lazy but paths and collections work.
2024-03-16_12-57-34.mp4
Video was the WIP version but gives you the idea.