Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Errors when a duplicate localization key is found. #4885

Merged
merged 13 commits into from
Jun 5, 2024
Merged

Write Errors when a duplicate localization key is found. #4885

merged 13 commits into from
Jun 5, 2024

Conversation

Ygg01
Copy link
Contributor

@Ygg01 Ygg01 commented Feb 2, 2024 •
edited
Loading

@metalgearsloth

  • Updated Linguini to v0.8.1 + Fixes.
  • Implemented tests for testing out load writing errors. Might need to be improved a bit.
  • Add SpyLogManager to spy on stuff being logged.

@Ygg01 Ygg01 changed the title Resource add error on initial loag Resource add error on initial load Feb 2, 2024
@Ygg01 Ygg01 changed the title Resource add error on initial load Resources write error on initial load Feb 2, 2024
@Ygg01
Copy link
Contributor Author

Ygg01 commented Feb 2, 2024

Fix duplicate commands in Robust. Content to be fixed at later date.

@Ygg01 Ygg01 changed the title Resources write error on initial load Write duplicate key error on initial load Feb 8, 2024
metalgearsloth added a commit to metalgearsloth/space-station-14 that referenced this pull request Apr 24, 2024
@metalgearsloth
Fix .ftl keys
7886fc0 
Required for space-wizards/RobustToolbox#4885 to not kill content
@metalgearsloth metalgearsloth mentioned this pull request Apr 24, 2024
Merged
EmoGarbage404 pushed a commit to space-wizards/space-station-14 that referenced this pull request Apr 25, 2024
@metalgearsloth
Fix .ftl keys (#27289)
f6ac494 
Required for space-wizards/RobustToolbox#4885 to not kill content
@Ygg01 Ygg01 mentioned this pull request May 6, 2024
Merged
@Ygg01 Ygg01 changed the title Write duplicate key error on initial load Write Errors when duplicate localization key is loaded. May 6, 2024
@Ygg01 Ygg01 mentioned this pull request May 6, 2024
Merged
@Ygg01 Ygg01 changed the title Write Errors when duplicate localization key is loaded. Write Errors when duplicate localization key is found. May 6, 2024
@Ygg01 Ygg01 changed the title Write Errors when duplicate localization key is found. Write Errors when a duplicate localization key is found. May 6, 2024
NullWanderer pushed a commit to NullWanderer/Delta-v that referenced this pull request May 6, 2024
@metalgearsloth @NullWanderer
Fix .ftl keys (#27289)
efa7b57 
Required for space-wizards/RobustToolbox#4885 to not kill content

(cherry picked from commit f6ac494)
@ElectroJr ElectroJr merged commit 9240c94 into space-wizards:master Jun 5, 2024
3 checks passed
DEATHB4DEFEAT pushed a commit to DEATHB4DEFEAT/Einstein-Engines that referenced this pull request Sep 21, 2024
@metalgearsloth @DEATHB4DEFEAT
Fix .ftl keys (#27289)
d2964d2 
Required for space-wizards/RobustToolbox#4885 to not kill content

(cherry picked from commit f6ac494ad3edb584d29f5bd71d4045d93ea9f55c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElectroJr ElectroJr ElectroJr approved these changes

@PJB3005 PJB3005 Awaiting requested review from PJB3005 PJB3005 is a code owner

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ygg01 @ElectroJr @metalgearsloth