[CONSUL-496] Replace docker_wget & docker_curl with docker_exec #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezfepo
force-pushed
the
windowstests/consul-496-replace-docker_wget-and-docker_curl-with-docker_exec
branch
from
22b7c5f to
e69f0e3
Compare
ezfepo
approved these changes
Sep 28, 2022
ezfepo
deleted the
windowstests/consul-496-replace-docker_wget-and-docker_curl-with-docker_exec
branch
cocolavayen
pushed a commit
that referenced
this pull request
Oct 3, 2022
ezfepo
pushed a commit
that referenced
this pull request
Oct 5, 2022
ezfepo
pushed a commit
that referenced
this pull request
Oct 18, 2022
ezfepo
pushed a commit
that referenced
this pull request
Nov 2, 2022
ezfepo
pushed a commit
that referenced
this pull request
Nov 2, 2022
ezfepo
pushed a commit
that referenced
this pull request
Nov 2, 2022
ezfepo
pushed a commit
that referenced
this pull request
Nov 11, 2022
joselo85
added a commit
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced docker_wget and docker_curl function calls with docker_exec (docker_consul_exec). This way we don't start any intermediate containers to capture logs after tests fail. docker_curl is used only once on wait_for_namespace function. Although this function is never used, it's been updated as well.