Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONSUL-466] Review case-grpc Failing Test #67

Merged
merged 1 commit into from
Sep 23, 2022
Merged

[CONSUL-466] Review case-grpc Failing Test #67

merged 1 commit into from
Sep 23, 2022

Conversation

joselo85
Copy link

Description

  • Deleted unused functions
  • Replaced retry_default for retry_long on failing test.
  • Updated must_match_in_statsd_logs functions to perform grep directly on the logs file.
  • Increased envoy_stats_flush_interval from 1s to 5s.

Everything was tested both on Linux and Windows. This test is now passing.

@joselo85 joselo85 self-assigned this Sep 22, 2022
cocolavayen
cocolavayen approved these changes Sep 23, 2022
View reviewed changes
Copy link

@cocolavayen cocolavayen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cocolavayen cocolavayen merged commit 788e41e into qa Sep 23, 2022
@cocolavayen cocolavayen deleted the windowstests/consul-466-review-case-grpc-failing-test branch September 23, 2022 16:10
cocolavayen pushed a commit that referenced this pull request Oct 3, 2022
@joselo85 @cocolavayen
[CONSUL-466] Review case-grpc Failing Test (#67)
8dd2256
ezfepo pushed a commit that referenced this pull request Oct 5, 2022
@joselo85 @ezfepo
[CONSUL-466] Review case-grpc Failing Test (#67)
d100a48
ezfepo pushed a commit that referenced this pull request Oct 18, 2022
@joselo85 @ezfepo
[CONSUL-466] Review case-grpc Failing Test (#67)
ccd6fd0
ezfepo pushed a commit that referenced this pull request Nov 2, 2022
@joselo85 @ezfepo
[CONSUL-466] Review case-grpc Failing Test (#67)
02e8bcc
ezfepo pushed a commit that referenced this pull request Nov 2, 2022
@joselo85 @ezfepo
[CONSUL-466] Review case-grpc Failing Test (#67)
2518c80
ezfepo pushed a commit that referenced this pull request Nov 2, 2022
@joselo85 @ezfepo
[CONSUL-466] Review case-grpc Failing Test (#67)
7191a42
ezfepo pushed a commit that referenced this pull request Nov 11, 2022
@joselo85 @ezfepo
[CONSUL-466] Review case-grpc Failing Test (#67)
4132934
joselo85 added a commit that referenced this pull request Dec 21, 2022
@joselo85
[CONSUL-466] Review case-grpc Failing Test (#67)
80bfa8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezfepo ezfepo ezfepo approved these changes

@cocolavayen cocolavayen cocolavayen approved these changes

Assignees

@joselo85 joselo85

Labels
script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joselo85 @ezfepo @cocolavayen