-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add properties to user resource for certificate creation #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detjensrobert
suggested changes
Dec 15, 2021
abbfad8
to
c9d9fcd
Compare
xorima
reviewed
Dec 16, 2021
c9d9fcd
to
45258db
Compare
detjensrobert
suggested changes
Feb 4, 2022
detjensrobert
previously approved these changes
Feb 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending on ci updates from #200
Signed-off-by: David Headrick <[email protected]>
Signed-off-by: David Headrick <[email protected]>
Signed-off-by: David Headrick <[email protected]>
Signed-off-by: David Headrick <[email protected]>
Signed-off-by: David Headrick <[email protected]>
Signed-off-by: David Headrick <[email protected]>
... convert bash resources to execute resources Signed-off-by: David Headrick <[email protected]>
e47269d
to
45bdd27
Compare
ramereth
approved these changes
Feb 24, 2022
Released as: 6.1.0 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds properties to the user resource of the openvpn cookbook. As a result, developers can specifically define attributes of the user certificate they want to create within a resource statement. Environment variables are updated in the server recipe to provide default values.