Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties to user resource for certificate creation #198

Merged
merged 8 commits into from
Feb 24, 2022

Conversation

daviddjh
Copy link
Contributor

Description

This change adds properties to the user resource of the openvpn cookbook. As a result, developers can specifically define attributes of the user certificate they want to create within a resource statement. Environment variables are updated in the server recipe to provide default values.

@daviddjh daviddjh requested a review from a team as a code owner December 15, 2021 22:31
@daviddjh daviddjh force-pushed the daviddjh/user_resource branch from abbfad8 to c9d9fcd Compare December 15, 2021 23:08
@xorima xorima added the Release: Minor Release to Chef Supermarket as a minor release when merged label Dec 16, 2021
@daviddjh daviddjh changed the title Daviddjh/user resource Add properties to user resource for certificate creation Dec 16, 2021
@damacus damacus added the Waiting on Contributor Awaiting on the person who raised this to update label Dec 20, 2021
@daviddjh daviddjh force-pushed the daviddjh/user_resource branch from c9d9fcd to 45258db Compare January 28, 2022 22:19
detjensrobert
detjensrobert previously approved these changes Feb 5, 2022
Copy link

@detjensrobert detjensrobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending on ci updates from #200

@ramereth ramereth removed the Waiting on Contributor Awaiting on the person who raised this to update label Feb 24, 2022
@ramereth ramereth merged commit fb4b07a into sous-chefs:main Feb 24, 2022
@kitchen-porter
Copy link
Contributor

Released as: 6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants