-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error due to missing method 'platform_family?' #96
Fix error due to missing method 'platform_family?' #96
Conversation
sous-chefs/consul#417 fixes the same issue in consul-cookbook. I based my changes on that PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a small note: it fixes the compatibility with Chef 12.6.0 and below.
This PR fixes a compatibility issue with Chef 12.6.0 and below. A Chef run exits with the following error message: ```No resource or method named `platform_family?' for `VaultCookbook::Provider::VaultService ""'```
c5be04c
to
3c8817a
Compare
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
====================================
Coverage 53% 53%
====================================
Files 2 2
Lines 100 100
====================================
Hits 53 53
Misses 47 47
Continue to review full report at Codecov.
|
@legal90 Thanks for the hint. I've changed the wording in the commit message. |
@legal90 I'd really like to get this merged so we can start using the cookbook. Anything else that needs to be done? Just let me know. |
@wndhydrnt Thank you! I guess, the Travis CI build failure will be fixed by #97 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR fixes a compatibility issue with Chef 12.6.0 and below.
A Chef run exits with the following error message:
No resource or method named `platform_family?' for `VaultCookbook::Provider::VaultService ""'