Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error due to missing method 'platform_family?' #96

Merged
merged 1 commit into from
Apr 9, 2017

Conversation

wndhydrnt
Copy link
Contributor

@wndhydrnt wndhydrnt commented Apr 4, 2017

This PR fixes a compatibility issue with Chef 12.6.0 and below.
A Chef run exits with the following error message:
No resource or method named `platform_family?' for `VaultCookbook::Provider::VaultService ""'

@wndhydrnt
Copy link
Contributor Author

sous-chefs/consul#417 fixes the same issue in consul-cookbook. I based my changes on that PR.

Copy link
Contributor

@legal90 legal90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small note: it fixes the compatibility with Chef 12.6.0 and below.

This PR fixes a compatibility issue with Chef 12.6.0 and below.
A Chef run exits with the following error message:
```No resource or method named `platform_family?' for `VaultCookbook::Provider::VaultService ""'```
@wndhydrnt wndhydrnt force-pushed the fix_platform_family_missing branch from c5be04c to 3c8817a Compare April 4, 2017 14:28
@codecov-io
Copy link

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #96   +/-   ##
====================================
  Coverage      53%   53%           
====================================
  Files           2     2           
  Lines         100   100           
====================================
  Hits           53    53           
  Misses         47    47
Impacted Files Coverage Δ
libraries/vault_service.rb 52.27% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe7912...3c8817a. Read the comment docs.

@wndhydrnt
Copy link
Contributor Author

@legal90 Thanks for the hint. I've changed the wording in the commit message.

@wndhydrnt
Copy link
Contributor Author

@legal90 I'd really like to get this merged so we can start using the cookbook. Anything else that needs to be done? Just let me know.

@legal90 legal90 merged commit 0a3d3e1 into sous-chefs:master Apr 9, 2017
@legal90
Copy link
Contributor

legal90 commented Apr 9, 2017

@wndhydrnt Thank you! I guess, the Travis CI build failure will be fixed by #97

@lock
Copy link

lock bot commented May 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants