Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra prams #78

Closed
wants to merge 7 commits into from
Closed

Extra prams #78

wants to merge 7 commits into from

Conversation

ericfode
Copy link
Contributor

@ericfode ericfode commented Nov 5, 2014

I want to disable remote exec with this http://www.consul.io/docs/agent/options.html#disable_remote_exec option. I figured other people might want to use other options so I made a way for you to pass arbitrary options to the consul service recipe.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.92%) when pulling 6e4ddaf on ericfode:patch-1 into 0d96fc4 on johnbellone:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.92%) when pulling c232ac0 on ericfode:patch-1 into 0d96fc4 on johnbellone:master.

@ericfode
Copy link
Contributor Author

ericfode commented Nov 5, 2014

Looking for away to pass in a hash of extra parameters, unfortunately the node object is not particularly amiable to copying, This is not ready yet, should I close it until it is?@johnbellone

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 362fab4 on ericfode:patch-1 into 0d96fc4 on johnbellone:master.

@ericfode
Copy link
Contributor Author

ericfode commented Nov 6, 2014

Now it is ready for review @johnbellone

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 55c133f on ericfode:patch-1 into 0d96fc4 on johnbellone:master.

@johnbellone johnbellone added this to the 0.5.0 milestone Nov 6, 2014
@ericfode
Copy link
Contributor Author

ericfode commented Nov 6, 2014

closing in favor of cleaner PR #85

@ericfode ericfode closed this Nov 6, 2014
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants