Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Add support for range spans #86

Merged
merged 2 commits into from
Feb 2, 2022
Merged

perf: Add support for range spans #86

merged 2 commits into from
Feb 2, 2022

Conversation

AndrewSisley
Copy link
Contributor

Closes #64

It is harder than it needs to be to test the range-span stuff as we don't yet have the functionality that uses it, so I have left the complicated part of the shim unimplemented - it can be done in the ticket that would use this system (then it can be properly tested by swapping the badger ds in the utils class for the map ds).

I couldnt find a way to retarget a PR, so if/when the parent branch gets merged and if people are happy with the proposed changes I'll create a new non-draft PR against develop.

@AndrewSisley AndrewSisley added feature New feature or request area/datastore Related to the datastore / storage engine system perf Performance issue or suggestion labels Dec 9, 2021
@AndrewSisley AndrewSisley self-assigned this Dec 9, 2021
@todo
Copy link

todo bot commented Dec 9, 2021

!!!!! - find and use parent prefix and then add filter(s) to the query object

defradb/datastores/iterable_transaction_shim.go

Lines 65 to 70 in 2d6e7ab

//todo!!!!! - find and use parent prefix and then add filter(s) to the query object
return nil, errors.New("Range spans are not currently supported on non-iterable transaction stores")
}
return shim.results, nil
}

This comment was generated by todo based on a todo comment in 2d6e7ab in #86. cc @sourcenetwork.

@AndrewSisley AndrewSisley linked an issue Dec 9, 2021 that may be closed by this pull request
Implement range spans #64
Closed
@AndrewSisley AndrewSisley force-pushed the sisley/perf/I60-badger-multi-scan branch 5 times, most recently from 4979346 to 3fbe92c Compare February 1, 2022 21:54
jsimnz
jsimnz approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks pretty good. very minor comments/clarification.

datastores/badger/v3/iterator.go Show resolved Hide resolved
db/collection_get.go Outdated Show resolved Hide resolved
@AndrewSisley AndrewSisley force-pushed the sisley/perf/I60-badger-multi-scan branch 4 times, most recently from a79d683 to b93bc96 Compare February 2, 2022 05:28
Base automatically changed from sisley/perf/I60-badger-multi-scan to develop February 2, 2022 05:31
@AndrewSisley AndrewSisley force-pushed the sisley/perf/I64-range-spans branch from 2d6e7ab to b323c93 Compare February 2, 2022 05:42
@codecov
Copy link

codecov bot commented Feb 2, 2022 •
edited
Loading

Codecov Report

Merging #86 (d58f033) into develop (4e88e92) will increase coverage by 0.05%.
The diff coverage is 70.12%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #86      +/-   ##
===========================================
+ Coverage    58.71%   58.76%   +0.05%     
===========================================
  Files           89       89              
  Lines         8531     8578      +47     
===========================================
+ Hits          5009     5041      +32     
- Misses        2980     2993      +13     
- Partials       542      544       +2
Impacted Files Coverage Δ
datastores/iterable/iterable_transaction_shim.go 64.58% <62.96%> (-3.28%) ⬇️
datastores/badger/v3/iterator.go 55.15% <72.34%> (+3.35%) ⬆️
db/fetcher/fetcher.go 63.59% <100.00%> (+0.16%) ⬆️
query/graphql/planner/select.go 78.65% <100.00%> (ø)

@AndrewSisley AndrewSisley marked this pull request as ready for review February 2, 2022 05:51
@jsimnz jsimnz added this to the DefraDB v0.2 milestone Feb 2, 2022
@AndrewSisley
Copy link
Contributor Author

Benchmarks look similar to dev, with some probable improvements in read speed (dev results are from a few hours ago (actually on the multi-scan branch), so maybe don't read to much into it, other than it is not significantly worse):

Benchmarks from branch:

goos: linux
goarch: amd64
pkg: github.com/sourcenetwork/defradb/bench/collection
cpu: Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz
Benchmark_Collection_UserSimple_CreateMany_Sync_0_10-8            12     231994486 ns/op
Benchmark_Collection_UserSimple_CreateMany_Sync_0_100-8            1    2568283675 ns/op
Benchmark_Collection_UserSimple_Create_Sync_0_1-8                100      22461552 ns/op
Benchmark_Collection_UserSimple_Create_Sync_0_10-8                13     247046722 ns/op
Benchmark_Collection_UserSimple_Create_Sync_0_100-8                1    2466437500 ns/op
Benchmark_Collection_UserSimple_Create_Sync_0_1000-8               1    29630683752 ns/op
Benchmark_Collection_UserSimple_Create_Async_0_1-8                63      19642555 ns/op
Benchmark_Collection_UserSimple_Create_Async_0_100-8               2    1019531120 ns/op
Benchmark_Collection_UserSimple_Create_Async_0_1000-8              1    16953419195 ns/op

...

Benchmark_Planner_UserSimple_ParseQuery-8           2845        419822 ns/op
Benchmark_Planner_UserSimple_MakePlan-8             6012        187300 ns/op
PASS
ok      github.com/sourcenetwork/defradb/bench/query/planner    2.844s
goos: linux
goarch: amd64
pkg: github.com/sourcenetwork/defradb/bench/query/simple
cpu: Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz
Benchmark_Query_UserSimple_Query_Sync_1-8                                933       1297377 ns/op
Benchmark_Query_UserSimple_Query_Sync_10-8                               463       2607386 ns/op
Benchmark_Query_UserSimple_Query_Sync_100-8                               52      22900986 ns/op
Benchmark_Query_UserSimple_Query_Sync_1000-8                               4     310120307 ns/op
Benchmark_Query_UserSimple_Query_WithFilter_Sync_1-8                     595       2009801 ns/op
Benchmark_Query_UserSimple_Query_WithFilter_Sync_10-8                    241       4948185 ns/op
Benchmark_Query_UserSimple_Query_WithFilter_Sync_100-8                    36      33821645 ns/op
Benchmark_Query_UserSimple_Query_WithFilter_Sync_1000-8                    3     367240331 ns/op
Benchmark_Query_UserSimple_Query_WithLimitOffset_Sync_1-8                601       1975414 ns/op
Benchmark_Query_UserSimple_Query_WithLimitOffset_Sync_10-8               242       4958169 ns/op
Benchmark_Query_UserSimple_Query_WithLimitOffset_Sync_100-8              181       8001410 ns/op
Benchmark_Query_UserSimple_Query_WithLimitOffset_Sync_1000-8             164       7994620 ns/op
Benchmark_Query_UserSimple_Query_WithMultiLookup_Sync_10-8                97      12458855 ns/op
Benchmark_Query_UserSimple_Query_WithMultiLookup_Sync_100-8               91      12635631 ns/op
Benchmark_Query_UserSimple_Query_WithMultiLookup_Sync_1000-8              87      13336455 ns/op
Benchmark_Query_UserSimple_Query_WithSingleLookup_Sync_1-8               596       1972227 ns/op
Benchmark_Query_UserSimple_Query_WithSingleLookup_Sync_10-8              586       2034037 ns/op
Benchmark_Query_UserSimple_Query_WithSingleLookup_Sync_100-8             588       2703974 ns/op
Benchmark_Query_UserSimple_Query_WithSingleLookup_Sync_1000-8            494       2259658 ns/op
Benchmark_Query_UserSimple_Query_WithSort_Sync_1-8                       580       2077235 ns/op
Benchmark_Query_UserSimple_Query_WithSort_Sync_10-8                      229       5176413 ns/op
Benchmark_Query_UserSimple_Query_WithSort_Sync_100-8                      33      35114355 ns/op
Benchmark_Query_UserSimple_Query_WithSort_Sync_1000-8                      3     356124314 ns/op
PASS
ok      github.com/sourcenetwork/defradb/bench/query/simple 326.468s
goos: linux
goarch: amd64
pkg: github.com/sourcenetwork/defradb/bench/storage
cpu: Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz
Benchmark_Storage_Simple_Read_Sync_1_1/ValueSize:0064-8               101740         12629 ns/op
Benchmark_Storage_Simple_Read_Sync_1_1/ValueSize:0128-8                98457         12164 ns/op
Benchmark_Storage_Simple_Read_Sync_1_1/ValueSize:0256-8                91833         12659 ns/op
Benchmark_Storage_Simple_Read_Sync_1_1/ValueSize:0512-8                87174         14895 ns/op
Benchmark_Storage_Simple_Read_Sync_1_1/ValueSize:1024-8                68186         17156 ns/op
Benchmark_Storage_Simple_Read_Sync_1_10/ValueSize:0064-8               10000        121155 ns/op
Benchmark_Storage_Simple_Read_Sync_1_10/ValueSize:0128-8               10000        121570 ns/op
Benchmark_Storage_Simple_Read_Sync_1_10/ValueSize:0256-8                8469        124769 ns/op
Benchmark_Storage_Simple_Read_Sync_1_10/ValueSize:0512-8                9099        138823 ns/op
Benchmark_Storage_Simple_Read_Sync_1_10/ValueSize:1024-8                6453        156810 ns/op
Benchmark_Storage_Simple_Read_Sync_1_100/ValueSize:0064-8                972       1201024 ns/op
Benchmark_Storage_Simple_Read_Sync_1_100/ValueSize:0128-8                968       1243601 ns/op
Benchmark_Storage_Simple_Read_Sync_1_100/ValueSize:0256-8                926       1263476 ns/op
Benchmark_Storage_Simple_Read_Sync_1_100/ValueSize:0512-8                865       1363087 ns/op
Benchmark_Storage_Simple_Read_Sync_1_100/ValueSize:1024-8                723       1612891 ns/op
Benchmark_Storage_Simple_Read_Sync_100_1/ValueSize:0064-8              78314         14056 ns/op
Benchmark_Storage_Simple_Read_Sync_100_1/ValueSize:0128-8              79099         14148 ns/op
Benchmark_Storage_Simple_Read_Sync_100_1/ValueSize:0256-8              81440         15270 ns/op
Benchmark_Storage_Simple_Read_Sync_100_1/ValueSize:0512-8              71708         16013 ns/op
Benchmark_Storage_Simple_Read_Sync_100_1/ValueSize:1024-8              59162         18510 ns/op
Benchmark_Storage_Simple_Read_Sync_100_10/ValueSize:0064-8              9315        138368 ns/op
Benchmark_Storage_Simple_Read_Sync_100_10/ValueSize:0128-8              9082        144810 ns/op
Benchmark_Storage_Simple_Read_Sync_100_10/ValueSize:0256-8              7610        147254 ns/op
Benchmark_Storage_Simple_Read_Sync_100_10/ValueSize:0512-8              7520        156398 ns/op
Benchmark_Storage_Simple_Read_Sync_100_10/ValueSize:1024-8              6651        184263 ns/op
Benchmark_Storage_Simple_Read_Sync_100_100/ValueSize:0064-8              880       1371142 ns/op
Benchmark_Storage_Simple_Read_Sync_100_100/ValueSize:0128-8              820       1413362 ns/op
Benchmark_Storage_Simple_Read_Sync_100_100/ValueSize:0256-8              800       1478503 ns/op
Benchmark_Storage_Simple_Read_Sync_100_100/ValueSize:0512-8              733       1627713 ns/op
Benchmark_Storage_Simple_Read_Sync_100_100/ValueSize:1024-8              648       1864956 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_1/ValueSize:0064-8            7158        169760 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_1/ValueSize:0128-8            7094        170229 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_1/ValueSize:0256-8            6886        175037 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_1/ValueSize:0512-8            6085        188189 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_1/ValueSize:1024-8            5704        209865 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-8           3616        397112 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-8           3158        416931 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-8           2941        472030 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-8           2391        542834 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-8           1773        717883 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-8           584       2534996 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-8           535       2589804 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-8           450       3918184 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-8           338       3780871 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-8           226       5634616 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_1/ValueSize:0064-8          6765        169836 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_1/ValueSize:0128-8          6979        170629 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_1/ValueSize:0256-8          6859        175694 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_1/ValueSize:0512-8          6505        186836 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_1/ValueSize:1024-8          5721        209364 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-8         3506        398065 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-8         3188        416182 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-8         2952        456212 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-8         2334        546159 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-8         1680        717641 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-8                 595       2574002 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-8                 424       2729322 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-8                 462       2986140 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-8                 333       3820854 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-8                 228       5421542 ns/op
Benchmark_Storage_Simple_Write_Sync_0_1/ValueSize:0064-8                       10000        116700 ns/op
Benchmark_Storage_Simple_Write_Sync_0_1/ValueSize:0128-8                       10000        120227 ns/op
Benchmark_Storage_Simple_Write_Sync_0_1/ValueSize:0256-8                        9832        124358 ns/op
Benchmark_Storage_Simple_Write_Sync_0_1/ValueSize:0512-8                        8431        135063 ns/op
Benchmark_Storage_Simple_Write_Sync_0_1/ValueSize:1024-8                        7905        153225 ns/op
Benchmark_Storage_Simple_Write_Sync_0_10/ValueSize:0064-8                       1045       1167496 ns/op
Benchmark_Storage_Simple_Write_Sync_0_10/ValueSize:0128-8                       1038       1195241 ns/op
Benchmark_Storage_Simple_Write_Sync_0_10/ValueSize:0256-8                        986       1245576 ns/op
Benchmark_Storage_Simple_Write_Sync_0_10/ValueSize:0512-8                        920       1353437 ns/op
Benchmark_Storage_Simple_Write_Sync_0_10/ValueSize:1024-8                        810       1526497 ns/op
Benchmark_Storage_Simple_Write_Sync_0_100/ValueSize:0064-8                        99      11767581 ns/op
Benchmark_Storage_Simple_Write_Sync_0_100/ValueSize:0128-8                        96      11961334 ns/op
Benchmark_Storage_Simple_Write_Sync_0_100/ValueSize:0256-8                        92      12423591 ns/op
Benchmark_Storage_Simple_Write_Sync_0_100/ValueSize:0512-8                        90      13482302 ns/op
Benchmark_Storage_Simple_Write_Sync_0_100/ValueSize:1024-8                        75      15504938 ns/op
Benchmark_Storage_Simple_Write_Sync_100_1/ValueSize:0064-8                     10000        118638 ns/op
Benchmark_Storage_Simple_Write_Sync_100_1/ValueSize:0128-8                     10000        119600 ns/op
Benchmark_Storage_Simple_Write_Sync_100_1/ValueSize:0256-8                      9582        128475 ns/op
Benchmark_Storage_Simple_Write_Sync_100_1/ValueSize:0512-8                      8017        135276 ns/op
Benchmark_Storage_Simple_Write_Sync_100_1/ValueSize:1024-8                      7728        154364 ns/op
Benchmark_Storage_Simple_Write_Sync_100_10/ValueSize:0064-8                     1011       1181659 ns/op
Benchmark_Storage_Simple_Write_Sync_100_10/ValueSize:0128-8                     1000       1199707 ns/op
Benchmark_Storage_Simple_Write_Sync_100_10/ValueSize:0256-8                      976       1254501 ns/op
Benchmark_Storage_Simple_Write_Sync_100_10/ValueSize:0512-8                      878       1346864 ns/op
Benchmark_Storage_Simple_Write_Sync_100_10/ValueSize:1024-8                      778       1547291 ns/op
Benchmark_Storage_Simple_Write_Sync_100_100/ValueSize:0064-8                      93      11711768 ns/op
Benchmark_Storage_Simple_Write_Sync_100_100/ValueSize:0128-8                     100      12032171 ns/op
Benchmark_Storage_Simple_Write_Sync_100_100/ValueSize:0256-8                      97      12471661 ns/op
Benchmark_Storage_Simple_Write_Sync_100_100/ValueSize:0512-8                      87      13556599 ns/op
Benchmark_Storage_Simple_Write_Sync_100_100/ValueSize:1024-8                      76      15305846 ns/op

From develop:

goos: linux
goarch: amd64
pkg: github.com/sourcenetwork/defradb/bench/collection
cpu: Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz
Benchmark_Collection_UserSimple_CreateMany_Sync_0_10-8             9     243187180 ns/op
Benchmark_Collection_UserSimple_CreateMany_Sync_0_100-8            1    2745112830 ns/op
Benchmark_Collection_UserSimple_Create_Sync_0_1-8                 62      20346360 ns/op
Benchmark_Collection_UserSimple_Create_Sync_0_10-8                10     226589456 ns/op
Benchmark_Collection_UserSimple_Create_Sync_0_100-8                1    2250266856 ns/op
Benchmark_Collection_UserSimple_Create_Sync_0_1000-8               1    29799735746 ns/op
Benchmark_Collection_UserSimple_Create_Async_0_1-8                60      19167256 ns/op
Benchmark_Collection_UserSimple_Create_Async_0_100-8               2    1416501997 ns/op
Benchmark_Collection_UserSimple_Create_Async_0_1000-8              1    17324384707 ns/op

...

Benchmark_Planner_UserSimple_ParseQuery-8           2544        412880 ns/op
Benchmark_Planner_UserSimple_MakePlan-8             5996        207696 ns/op
PASS
ok      github.com/sourcenetwork/defradb/bench/query/planner    3.582s
goos: linux
goarch: amd64
pkg: github.com/sourcenetwork/defradb/bench/query/simple
cpu: Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz
Benchmark_Query_UserSimple_Query_Sync_1-8                                894       1270251 ns/op
Benchmark_Query_UserSimple_Query_Sync_10-8                               373       2699876 ns/op
Benchmark_Query_UserSimple_Query_Sync_100-8                               50      22466270 ns/op
Benchmark_Query_UserSimple_Query_Sync_1000-8                               3     403098025 ns/op
Benchmark_Query_UserSimple_Query_WithFilter_Sync_1-8                     585       2027252 ns/op
Benchmark_Query_UserSimple_Query_WithFilter_Sync_10-8                    211       5021560 ns/op
Benchmark_Query_UserSimple_Query_WithFilter_Sync_100-8                    33      38604404 ns/op
Benchmark_Query_UserSimple_Query_WithFilter_Sync_1000-8                    3     477738574 ns/op
Benchmark_Query_UserSimple_Query_WithLimitOffset_Sync_1-8                565       2133137 ns/op
Benchmark_Query_UserSimple_Query_WithLimitOffset_Sync_10-8               195       5496067 ns/op
Benchmark_Query_UserSimple_Query_WithLimitOffset_Sync_100-8              160       9156632 ns/op
Benchmark_Query_UserSimple_Query_WithLimitOffset_Sync_1000-8              92      11406405 ns/op
Benchmark_Query_UserSimple_Query_WithMultiLookup_Sync_10-8                86      13351185 ns/op
Benchmark_Query_UserSimple_Query_WithMultiLookup_Sync_100-8               86      13503928 ns/op
Benchmark_Query_UserSimple_Query_WithMultiLookup_Sync_1000-8              64      19924133 ns/op
Benchmark_Query_UserSimple_Query_WithSingleLookup_Sync_1-8               561       2107686 ns/op
Benchmark_Query_UserSimple_Query_WithSingleLookup_Sync_10-8              548       2153916 ns/op
Benchmark_Query_UserSimple_Query_WithSingleLookup_Sync_100-8             528       2267160 ns/op
Benchmark_Query_UserSimple_Query_WithSingleLookup_Sync_1000-8            344       2974032 ns/op
Benchmark_Query_UserSimple_Query_WithSort_Sync_1-8                       537       2214274 ns/op
Benchmark_Query_UserSimple_Query_WithSort_Sync_10-8                      189       5779045 ns/op
Benchmark_Query_UserSimple_Query_WithSort_Sync_100-8                      28      44124662 ns/op
Benchmark_Query_UserSimple_Query_WithSort_Sync_1000-8                      3     464295772 ns/op
PASS
ok      github.com/sourcenetwork/defradb/bench/query/simple 560.847s
goos: linux
goarch: amd64
pkg: github.com/sourcenetwork/defradb/bench/storage
cpu: Intel(R) Core(TM) i5-8300H CPU @ 2.30GHz
Benchmark_Storage_Simple_Read_Sync_1_1/ValueSize:0064-8                88603         12552 ns/op
Benchmark_Storage_Simple_Read_Sync_1_1/ValueSize:0128-8                94545         12933 ns/op
Benchmark_Storage_Simple_Read_Sync_1_1/ValueSize:0256-8                90648         13060 ns/op
Benchmark_Storage_Simple_Read_Sync_1_1/ValueSize:0512-8                85755         13612 ns/op
Benchmark_Storage_Simple_Read_Sync_1_1/ValueSize:1024-8                67999         16305 ns/op
Benchmark_Storage_Simple_Read_Sync_1_10/ValueSize:0064-8                8994        121910 ns/op
Benchmark_Storage_Simple_Read_Sync_1_10/ValueSize:0128-8                9025        123073 ns/op
Benchmark_Storage_Simple_Read_Sync_1_10/ValueSize:0256-8                8832        136605 ns/op
Benchmark_Storage_Simple_Read_Sync_1_10/ValueSize:0512-8                7654        152236 ns/op
Benchmark_Storage_Simple_Read_Sync_1_10/ValueSize:1024-8                6014        188976 ns/op
Benchmark_Storage_Simple_Read_Sync_1_100/ValueSize:0064-8                916       1326292 ns/op
Benchmark_Storage_Simple_Read_Sync_1_100/ValueSize:0128-8                928       1303539 ns/op
Benchmark_Storage_Simple_Read_Sync_1_100/ValueSize:0256-8                908       1308950 ns/op
Benchmark_Storage_Simple_Read_Sync_1_100/ValueSize:0512-8                807       1464784 ns/op
Benchmark_Storage_Simple_Read_Sync_1_100/ValueSize:1024-8                660       1573795 ns/op
Benchmark_Storage_Simple_Read_Sync_100_1/ValueSize:0064-8              82942         14316 ns/op
Benchmark_Storage_Simple_Read_Sync_100_1/ValueSize:0128-8              84385         15118 ns/op
Benchmark_Storage_Simple_Read_Sync_100_1/ValueSize:0256-8              76015         14880 ns/op
Benchmark_Storage_Simple_Read_Sync_100_1/ValueSize:0512-8              63942         16495 ns/op
Benchmark_Storage_Simple_Read_Sync_100_1/ValueSize:1024-8              61354         19670 ns/op
Benchmark_Storage_Simple_Read_Sync_100_10/ValueSize:0064-8              8212        141801 ns/op
Benchmark_Storage_Simple_Read_Sync_100_10/ValueSize:0128-8              7772        141227 ns/op
Benchmark_Storage_Simple_Read_Sync_100_10/ValueSize:0256-8              7471        151593 ns/op
Benchmark_Storage_Simple_Read_Sync_100_10/ValueSize:0512-8              6682        158443 ns/op
Benchmark_Storage_Simple_Read_Sync_100_10/ValueSize:1024-8              6034        185481 ns/op
Benchmark_Storage_Simple_Read_Sync_100_100/ValueSize:0064-8              889       1387460 ns/op
Benchmark_Storage_Simple_Read_Sync_100_100/ValueSize:0128-8              829       1498827 ns/op
Benchmark_Storage_Simple_Read_Sync_100_100/ValueSize:0256-8              771       1523385 ns/op
Benchmark_Storage_Simple_Read_Sync_100_100/ValueSize:0512-8              739       1591666 ns/op
Benchmark_Storage_Simple_Read_Sync_100_100/ValueSize:1024-8              645       1821382 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_1/ValueSize:0064-8            6523        178796 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_1/ValueSize:0128-8            6397        182121 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_1/ValueSize:0256-8            6194        188739 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_1/ValueSize:0512-8            5727        204451 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_1/ValueSize:1024-8            4935        236104 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-8           2698        444945 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-8           2504        478294 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-8           2166        543099 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-8           1808        663470 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-8           1305        959012 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-8           415       2969197 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-8           385       3832823 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-8           308       5076291 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-8           234       5252384 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-8           154       7935671 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_1/ValueSize:0064-8          6444        178154 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_1/ValueSize:0128-8          6412        178915 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_1/ValueSize:0256-8          6150        187737 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_1/ValueSize:0512-8          5683        203650 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_1/ValueSize:1024-8          4875        234201 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-8         2682        446590 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-8         2515        477534 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-8         2233        545660 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-8         1807        665783 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-8         1252       1140755 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-8                 414       2941438 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-8                 289       3491351 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-8                 302       3690479 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-8                 231       5119448 ns/op
Benchmark_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-8                 150       7476156 ns/op
Benchmark_Storage_Simple_Write_Sync_0_1/ValueSize:0064-8                        9192        124358 ns/op
Benchmark_Storage_Simple_Write_Sync_0_1/ValueSize:0128-8                        8840        128151 ns/op
Benchmark_Storage_Simple_Write_Sync_0_1/ValueSize:0256-8                        8532        135479 ns/op
Benchmark_Storage_Simple_Write_Sync_0_1/ValueSize:0512-8                        7621        155178 ns/op
Benchmark_Storage_Simple_Write_Sync_0_1/ValueSize:1024-8                        6462        189510 ns/op
Benchmark_Storage_Simple_Write_Sync_0_10/ValueSize:0064-8                        872       1296895 ns/op
Benchmark_Storage_Simple_Write_Sync_0_10/ValueSize:0128-8                        930       1280023 ns/op
Benchmark_Storage_Simple_Write_Sync_0_10/ValueSize:0256-8                        885       1363668 ns/op
Benchmark_Storage_Simple_Write_Sync_0_10/ValueSize:0512-8                        804       1491563 ns/op
Benchmark_Storage_Simple_Write_Sync_0_10/ValueSize:1024-8                        680       1771564 ns/op
Benchmark_Storage_Simple_Write_Sync_0_100/ValueSize:0064-8                        92      13618863 ns/op
Benchmark_Storage_Simple_Write_Sync_0_100/ValueSize:0128-8                        88      13306622 ns/op
Benchmark_Storage_Simple_Write_Sync_0_100/ValueSize:0256-8                        76      13597377 ns/op
Benchmark_Storage_Simple_Write_Sync_0_100/ValueSize:0512-8                        78      14984962 ns/op
Benchmark_Storage_Simple_Write_Sync_0_100/ValueSize:1024-8                        66      17747707 ns/op
Benchmark_Storage_Simple_Write_Sync_100_1/ValueSize:0064-8                      9098        124415 ns/op
Benchmark_Storage_Simple_Write_Sync_100_1/ValueSize:0128-8                      8817        128719 ns/op
Benchmark_Storage_Simple_Write_Sync_100_1/ValueSize:0256-8                      8449        137050 ns/op
Benchmark_Storage_Simple_Write_Sync_100_1/ValueSize:0512-8                      7533        150149 ns/op
Benchmark_Storage_Simple_Write_Sync_100_1/ValueSize:1024-8                      6367        177450 ns/op
Benchmark_Storage_Simple_Write_Sync_100_10/ValueSize:0064-8                      960       1246423 ns/op
Benchmark_Storage_Simple_Write_Sync_100_10/ValueSize:0128-8                      927       1285406 ns/op
Benchmark_Storage_Simple_Write_Sync_100_10/ValueSize:0256-8                      886       1349290 ns/op
Benchmark_Storage_Simple_Write_Sync_100_10/ValueSize:0512-8                      798       1496086 ns/op
Benchmark_Storage_Simple_Write_Sync_100_10/ValueSize:1024-8                      668       1771530 ns/op
Benchmark_Storage_Simple_Write_Sync_100_100/ValueSize:0064-8                      93      12432176 ns/op
Benchmark_Storage_Simple_Write_Sync_100_100/ValueSize:0128-8                      90      13064219 ns/op
Benchmark_Storage_Simple_Write_Sync_100_100/ValueSize:0256-8                      82      13597134 ns/op
Benchmark_Storage_Simple_Write_Sync_100_100/ValueSize:0512-8                      79      14926321 ns/op
Benchmark_Storage_Simple_Write_Sync_100_100/ValueSize:1024-8                      64      17810755 ns/op

@AndrewSisley AndrewSisley force-pushed the sisley/perf/I64-range-spans branch from b323c93 to d58f033 Compare February 2, 2022 06:19
@AndrewSisley AndrewSisley merged commit b636a9e into develop Feb 2, 2022
@AndrewSisley AndrewSisley deleted the sisley/perf/I64-range-spans branch February 2, 2022 06:22
jsimnz pushed a commit that referenced this pull request Feb 7, 2022
@AndrewSisley @jsimnz
perf: Add support for range spans (#86)
8a4acf6 
* Correctly prefix dockey filter's span end

* Add support for range spans
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@AndrewSisley
perf: Add support for range spans (sourcenetwork#86)
e548228 
* Correctly prefix dockey filter's span end

* Add support for range spans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsimnz jsimnz jsimnz approved these changes

@shahzadlone shahzadlone Awaiting requested review from shahzadlone

Assignees

@AndrewSisley AndrewSisley

Labels
area/datastore Related to the datastore / storage engine system feature New feature or request perf Performance issue or suggestion
Projects
None yet
Milestone
DefraDB v0.2
Development

Successfully merging this pull request may close these issues.

Implement range spans
2 participants
@AndrewSisley @jsimnz