Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve code documentation #533

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented Jun 17, 2022

Relevant issue(s)

Resolves #496 #154

Description

Improves in-repo documentation and the feel of the rendered code documentation.

It is meant to be a collaborative draft PR, in which we can all feel free to push commits improving the documentation onto the branch.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

This should only touch (code) documentation.

@orpheuslummis orpheuslummis added the documentation Improvements or additions to documentation label Jun 17, 2022
@orpheuslummis orpheuslummis self-assigned this Jun 17, 2022
@orpheuslummis orpheuslummis added the action/no-benchmark Skips the action that runs the benchmark. label Jun 17, 2022
@sourcenetwork sourcenetwork deleted a comment from source-devs Jun 17, 2022
@sourcenetwork sourcenetwork deleted a comment from codecov bot Jun 17, 2022
@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #533 (02ef2d7) into develop (10f5fb0) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #533      +/-   ##
===========================================
- Coverage    56.59%   56.58%   -0.01%     
===========================================
  Files          121      121              
  Lines        14083    14082       -1     
===========================================
- Hits          7970     7969       -1     
  Misses        5421     5421              
  Partials       692      692              
Impacted Files Coverage Δ
api/http/router.go 100.00% <ø> (ø)
api/http/server.go 100.00% <ø> (ø)
client/dockey.go 51.16% <ø> (ø)
core/crdt/composite.go 76.05% <ø> (ø)
core/crdt/lwwreg.go 74.39% <ø> (ø)
core/data.go 88.73% <ø> (ø)
core/doc.go 93.61% <ø> (ø)
core/key.go 85.97% <ø> (ø)
datastore/blockstore.go 45.05% <ø> (ø)
datastore/dag.go 100.00% <ø> (ø)
... and 27 more

@fredcarle
Copy link
Collaborator

Good first effort on this Orphée!

@orpheuslummis orpheuslummis force-pushed the orpheus/docs/code-documentation-improvement branch from 99a2f58 to 542df2d Compare June 27, 2022 23:45
@orpheuslummis orpheuslummis marked this pull request as ready for review June 27, 2022 23:45
@orpheuslummis orpheuslummis requested a review from a team June 27, 2022 23:45
@orpheuslummis orpheuslummis force-pushed the orpheus/docs/code-documentation-improvement branch from 6ac7a8a to 02ef2d7 Compare June 28, 2022 00:25
@orpheuslummis
Copy link
Contributor Author

orpheuslummis commented Jun 28, 2022

closes #154
adding this comment to include the issue because it didn't worked as part of the PR text
update: this doesn't work either so the issue will be closed after the fact

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers for taking the time to do this. One suggestion I would offer for the future however is to group changes under different commits - would make reviewing a bit easier (e.g. lets=>let's in a single commit, then reviews can skim through similar no-brainers more easily and with less risk of missing more complex changes such as rewordings).

@orpheuslummis
Copy link
Contributor Author

LGTM! Cheers for taking the time to do this. One suggestion I would offer for the future however is to group changes under different commits - would make reviewing a bit easier (e.g. lets=>let's in a single commit, then reviews can skim through similar no-brainers more easily and with less risk of missing more complex changes such as rewordings).

I agree! I've always appreciated when you do it. Thanks

@orpheuslummis orpheuslummis merged commit 3957381 into develop Jun 28, 2022
@orpheuslummis orpheuslummis deleted the orpheus/docs/code-documentation-improvement branch June 28, 2022 13:17
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various typo (crowdsourcing)
3 participants