-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve code documentation #533
docs: Improve code documentation #533
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #533 +/- ##
===========================================
- Coverage 56.59% 56.58% -0.01%
===========================================
Files 121 121
Lines 14083 14082 -1
===========================================
- Hits 7970 7969 -1
Misses 5421 5421
Partials 692 692
|
Good first effort on this Orphée! |
99a2f58
to
542df2d
Compare
6ac7a8a
to
02ef2d7
Compare
closes #154 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Cheers for taking the time to do this. One suggestion I would offer for the future however is to group changes under different commits - would make reviewing a bit easier (e.g. lets=>let's in a single commit, then reviews can skim through similar no-brainers more easily and with less risk of missing more complex changes such as rewordings).
I agree! I've always appreciated when you do it. Thanks |
Relevant issue(s)
Resolves #496 #154
Description
Improves in-repo documentation and the feel of the rendered code documentation.
It is meant to be a collaborative draft PR, in which we can all feel free to push commits improving the documentation onto the branch.
Tasks
How has this been tested?
This should only touch (code) documentation.