-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Test against file system #128
test: Test against file system #128
Conversation
d145736
to
c4c0a17
Compare
Spoke over discord some things were agreed:
|
35d79d1
to
691b3c2
Compare
Codecov Report
@@ Coverage Diff @@
## develop #128 +/- ##
========================================
Coverage 54.09% 54.09%
========================================
Files 35 35
Lines 3629 3629
========================================
Hits 1963 1963
Misses 1437 1437
Partials 229 229
|
411f55b
to
fb489fd
Compare
Was way easier to do this than I expected - t.TempDir is super handy to have (it also handles teardown and provides a unique dir per test) :) |
Is off by default, should be toggled on for the CI builds though
fb489fd
to
0a6528d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ezpz. LGTM
…ourcenetwork#128) Is off by default, should be toggled on for the CI builds though
Closes #127
Todo: