Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update go-libp2p to 0.26.4 #1257

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

AndrewSisley
Copy link
Contributor

Relevant issue(s)

Resolves #1256

Description

Updates go-libp2p to 0.26.4 from 0.26.0 - this might significantly reduce our test flakiness, but we should do it anyway (odd that dependabot didnt do this).

@AndrewSisley AndrewSisley added area/p2p Related to the p2p networking system action/no-benchmark Skips the action that runs the benchmark. bump Bumped version for something labels Mar 29, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.5 milestone Mar 29, 2023
@AndrewSisley AndrewSisley requested a review from a team March 29, 2023 18:48
@AndrewSisley AndrewSisley self-assigned this Mar 29, 2023
@AndrewSisley AndrewSisley changed the title chore: Update lib-p2p to 0.26.4 chore: Update go-libp2p to 0.26.4 Mar 29, 2023
@AndrewSisley AndrewSisley force-pushed the sisley/chore/I1256-update-libp2p branch from a0c48e2 to b67f359 Compare March 29, 2023 18:49
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for that update.

@AndrewSisley
Copy link
Contributor Author

Lol... P2P tests timed out in this PR

@fredcarle
Copy link
Collaborator

Lol... P2P tests timed out in this PR

I wasn't expecting that to fix our flakiness. It fixes it on their side but the timing of execution on our side is independent of libp2p. It's nice to have the latest version of the package though.

@AndrewSisley AndrewSisley merged commit 9e090b2 into develop Mar 29, 2023
@AndrewSisley AndrewSisley deleted the sisley/chore/I1256-update-libp2p branch March 29, 2023 19:17
shahzadlone pushed a commit that referenced this pull request Apr 13, 2023
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/p2p Related to the p2p networking system bump Bumped version for something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update go-libp2p to 0.26.4
2 participants