Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests bypass most of node package #2634

Closed
AndrewSisley opened this issue May 21, 2024 · 0 comments · Fixed by #2641
Closed

Integration tests bypass most of node package #2634

AndrewSisley opened this issue May 21, 2024 · 0 comments · Fixed by #2641
Assignees
@AndrewSisley
Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Milestone
DefraDB v0.12

Comments

@AndrewSisley
Copy link
Contributor

The integration tests always create DB instances using the db constructor, and thus skip most of the code in the node package (as well as testing using internal funcs).

Change this to use the node package and the public options within it.
@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite code quality Related to improving code quality labels May 21, 2024
@AndrewSisley AndrewSisley mentioned this issue May 21, 2024
Merged
@AndrewSisley AndrewSisley self-assigned this May 22, 2024
@AndrewSisley AndrewSisley mentioned this issue May 22, 2024
Merged
@AndrewSisley AndrewSisley added this to the DefraDB v0.12 milestone May 22, 2024
AndrewSisley added a commit that referenced this issue May 22, 2024
@AndrewSisley
test: Test node pkg constructor via integration test suite (#2641)
d10d5a6 
## Relevant issue(s)

Resolves #2634

## Description

Tests node pkg constructor via integration test suite instead of
bypassing it and directly creating `db` instances via the `db` package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.12
Development

Successfully merging a pull request may close this issue.

test: Test node pkg constructor via integration test suite AndrewSisley/defradb
1 participant
@AndrewSisley