Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test single delete doc operation #163

Closed
shahzadlone opened this issue Feb 1, 2022 · 0 comments · Fixed by #150
Closed

Test single delete doc operation #163

shahzadlone opened this issue Feb 1, 2022 · 0 comments · Fixed by #150
Assignees
@shahzadlone
Labels
area/testing Related to any test or testing suite
Milestone
DefraDB v0.2

Comments

@shahzadlone
Copy link
Member

Don't forget to add tests for single delete doc operation
@shahzadlone shahzadlone added the area/testing Related to any test or testing suite label Feb 1, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.2.1 milestone Feb 1, 2022
@shahzadlone shahzadlone mentioned this issue Feb 2, 2022
Merged
shahzadlone added a commit that referenced this issue Feb 2, 2022
@shahzadlone
feat: Add Document Deletion with a Key (#150)
9d822c3 
This enables the deletion of a single document using their dockey.

The query will look like something like this:

mutation {
    delete_user(id: "bae-6a6482a8-24e1-5c73-a237-ca569e41507d") {
        deletedDocKey: _key
    }
}
Note: deletedDocKey is an alias of a deleted key.

This PR resolves and closes #32 and #163

Future Work:

Implement the deletion of multiple documents using multiple keys.
Implement the deletion of documents using filters.
@shahzadlone shahzadlone linked a pull request Feb 2, 2022 that will close this issue
feat: Add Document Deletion with a Key #150
Merged
@shahzadlone shahzadlone self-assigned this Feb 2, 2022
@jsimnz jsimnz closed this as completed Feb 4, 2022
jsimnz pushed a commit that referenced this issue Feb 7, 2022
@shahzadlone @jsimnz
feat: Add Document Deletion with a Key (#150)
48fa15b 
This enables the deletion of a single document using their dockey.

The query will look like something like this:

mutation {
    delete_user(id: "bae-6a6482a8-24e1-5c73-a237-ca569e41507d") {
        deletedDocKey: _key
    }
}
Note: deletedDocKey is an alias of a deleted key.

This PR resolves and closes #32 and #163

Future Work:

Implement the deletion of multiple documents using multiple keys.
Implement the deletion of documents using filters.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
feat: Add Document Deletion with a Key (sourcenetwork#150)
26a7833 
This enables the deletion of a single document using their dockey.

The query will look like something like this:

mutation {
    delete_user(id: "bae-6a6482a8-24e1-5c73-a237-ca569e41507d") {
        deletedDocKey: _key
    }
}
Note: deletedDocKey is an alias of a deleted key.

This PR resolves and closes sourcenetwork#32 and sourcenetwork#163

Future Work:

Implement the deletion of multiple documents using multiple keys.
Implement the deletion of documents using filters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
area/testing Related to any test or testing suite
Projects
None yet
Milestone
DefraDB v0.2
Development

Successfully merging a pull request may close this issue.

feat: Add Document Deletion with a Key sourcenetwork/defradb
2 participants
@jsimnz @shahzadlone