Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using pipe for logger in tests can result in a race condition #1607

Closed
fredcarle opened this issue Jul 4, 2023 · 0 comments · Fixed by #1608
Closed

Using pipe for logger in tests can result in a race condition #1607

fredcarle opened this issue Jul 4, 2023 · 0 comments · Fixed by #1608
Assignees
@fredcarle
Labels
bug Something isn't working
Milestone
DefraDB v0.6

Comments

@fredcarle
Copy link
Collaborator

Using pipe for logger in tests can result in a race condition if multiple go routines call a log function.
@fredcarle fredcarle added the bug Something isn't working label Jul 4, 2023
@fredcarle fredcarle added this to the DefraDB v0.6 milestone Jul 4, 2023
@fredcarle fredcarle self-assigned this Jul 4, 2023
@fredcarle fredcarle mentioned this issue Jul 4, 2023
Merged
4 tasks
fredcarle added a commit that referenced this issue Jul 4, 2023
@fredcarle
fix: Change the WriteSyncer to use lock when piping (#1608)
5f4beb9 
## Relevant issue(s)

Resolves #1607

## Description

This PR wraps the pipe WriteSyncer with a Lock so that is can be used
concurrently.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
fix: Change the WriteSyncer to use lock when piping (sourcenetwork#1608)
d3cbc24 
## Relevant issue(s)

Resolves sourcenetwork#1607

## Description

This PR wraps the pipe WriteSyncer with a Lock so that is can be used
concurrently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.6
Development

Successfully merging a pull request may close this issue.

fix: Change the WriteSyncer to use lock when piping fredcarle/defradb
1 participant
@fredcarle