Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code covs flakey fails and don't run on fork pushes #1413

Closed
shahzadlone opened this issue Apr 27, 2023 · 0 comments · Fixed by #1414
Closed

Fix code covs flakey fails and don't run on fork pushes #1413

shahzadlone opened this issue Apr 27, 2023 · 0 comments · Fixed by #1414
Assignees
@shahzadlone
Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Milestone
DefraDB v0.5.1

Comments

@shahzadlone
Copy link
Member

Fix code covs flakey behavior and don't run on fork pushes
@shahzadlone shahzadlone added the ci/build This is issue is about the build or CI system, and the administration of it. label Apr 27, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5.1 milestone Apr 27, 2023
@shahzadlone shahzadlone self-assigned this Apr 27, 2023
@shahzadlone shahzadlone mentioned this issue Apr 27, 2023
Merged
shahzadlone added a commit that referenced this issue May 17, 2023
@shahzadlone
ci: Reconfigure CodeCov action to ensure stability (#1414)
0621856 
## Relevant issue(s)
Resolves #1413

## Description
- Ensures Codecov doesn't run on every push (code coverage reports will
only generate for every PR, or pushes on `master` and `develop`). This
also means contributors don't need to have codecov to have a build run
successfully on their fork pushes.
- If for whatever reason the code cov token doesn't exist, still run the
action (but might be flakey - so retry until passes up to 5 times).

Future: Should probably rework this to do the `pull_request` -> trigger
a `workflow_run` that will be passed the code coverage report that will
then have the secrets in the second privileged action run. But until
then hopefully this can get us by.

## How has this been tested?
Fork pushes and this PR pushes.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
ci: Reconfigure CodeCov action to ensure stability (sourcenetwork#1414)
33a0ef3 
## Relevant issue(s)
Resolves sourcenetwork#1413

## Description
- Ensures Codecov doesn't run on every push (code coverage reports will
only generate for every PR, or pushes on `master` and `develop`). This
also means contributors don't need to have codecov to have a build run
successfully on their fork pushes.
- If for whatever reason the code cov token doesn't exist, still run the
action (but might be flakey - so retry until passes up to 5 times).

Future: Should probably rework this to do the `pull_request` -> trigger
a `workflow_run` that will be passed the code coverage report that will
then have the secrets in the second privileged action run. But until
then hopefully this can get us by.

## How has this been tested?
Fork pushes and this PR pushes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
DefraDB v0.5.1
Development

Successfully merging a pull request may close this issue.

ci: Reconfigure CodeCov action to ensure stability shahzadlone/defradb
1 participant
@shahzadlone