Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction conflict possibility on P2P ProcessLog #1030

Closed
fredcarle opened this issue Jan 13, 2023 · 0 comments · Fixed by #1031
Closed

Transaction conflict possibility on P2P ProcessLog #1030

fredcarle opened this issue Jan 13, 2023 · 0 comments · Fixed by #1031
Assignees
@fredcarle
Labels
area/p2p Related to the p2p networking system bug Something isn't working
Milestone
DefraDB v0.5

Comments

@fredcarle
Copy link
Collaborator

There is potential for a transaction conflict on the processing of a log in the pubsub process when multiple logs are receive concurrently.
@fredcarle fredcarle added bug Something isn't working area/p2p Related to the p2p networking system labels Jan 13, 2023
@fredcarle fredcarle added this to the DefraDB v0.5 milestone Jan 13, 2023
@fredcarle fredcarle self-assigned this Jan 13, 2023
@fredcarle fredcarle mentioned this issue Jan 13, 2023
Merged
4 tasks
shahzadlone pushed a commit that referenced this issue Apr 13, 2023
@fredcarle @shahzadlone
fix: Improve DAG sync with highly concurrent updates (#1031)
2784800 
Relevant issue(s)
Resolves #1029
Resolves #1030

Description
This PR resolves the eventual consistency bug when highly concurrent updates would cause the DAG syncer to fail reaching consistency. It also adds a simple retry mechanic to avoid sync issues when there is a transaction conflict on the head store.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
fix: Improve DAG sync with highly concurrent updates (sourcenetwork#1031
d9a4419 
)

Relevant issue(s)
Resolves sourcenetwork#1029
Resolves sourcenetwork#1030

Description
This PR resolves the eventual consistency bug when highly concurrent updates would cause the DAG syncer to fail reaching consistency. It also adds a simple retry mechanic to avoid sync issues when there is a transaction conflict on the head store.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/p2p Related to the p2p networking system bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging a pull request may close this issue.

fix: Improve DAG sync with highly concurrent updates sourcenetwork/defradb
1 participant
@fredcarle