Return error if field to count is not specified

sourcenetwork · Jan 25, 2022 · 26c6861 · 26c6861
1 parent d7aea48
commit 26c6861
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/db/tests/query/simple/with_group_count_test.go b/db/tests/query/simple/with_group_count_test.go
@@ -133,16 +133,7 @@ func TestQuerySimpleWithGroupByNumberWithUndefinedField(t *testing.T) {
 				"Age": 19
 			}`)},
 		},
-		Results: []map[string]interface{}{
-			{
-				"Age":    uint64(32),
-				"_count": 0,
-			},
-			{
-				"Age":    uint64(19),
-				"_count": 0,
-			},
-		},
+		ExpectedError: "Count must be provided with a property to count.",
 	}
 
 	executeTestCase(t, test)

diff --git a/query/graphql/planner/count.go b/query/graphql/planner/count.go
@@ -14,6 +14,7 @@ package planner
 // aggregates in.
 
 import (
+	"fmt"
 	"reflect"
 
 	"github.com/sourcenetwork/defradb/core"
@@ -29,6 +30,10 @@ type countNode struct {
 }
 
 func (p *Planner) Count(c *parser.Count, virtualFieldId string) (*countNode, error) {
+	if c.Field == "" {
+		return nil, fmt.Errorf("Count must be provided with a property to count.")
+	}
+
 	return &countNode{
 		p:              p,
 		sourceProperty: c.Field,