This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Ensure WORKERS is respected in syntect server image as env var #59018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 474813e...8ce7c4a.
|
varungandhi-src
approved these changes
Dec 15, 2023
| # bad grammar/file combinations. If it happens with four workers, only 1/4th of | ||
| # requests will be affected for a short period of time. Each worker can require | ||
| # at peak around 1.1 GiB of memory. | ||
| "-workers=$WORKERS", |
There was a problem hiding this comment.
Is WORKERS guaranteed to be set? If not, should we have a default value here?
There was a problem hiding this comment.
Checking this as part of the review:
~/work/sourcegraph dax/update_syntect_server $ docker load --input=bazel-bin/docker-images/syntax-highlighter/image_tarball/tarball.tar
69635e4afa19: Loading layer [==================================================>] 23.22MB/23.22MB
9eb57e8e2f08: Loading layer [==================================================>] 14.48MB/14.48MB
Loaded image: syntect-server:candidate
~/work/sourcegraph dax/update_syntect_server $ ba
~/work/sourcegraph dax/update_syntect_server $ docker run --rm --entrypoint=/bin/sh -it syntect-server:candidate
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
/ # env
WORKERS=4
jhchabran
approved these changes
Dec 15, 2023
|
Minor improvement but this a bandaid instead of attempting https://github.com/sourcegraph/sourcegraph/issues/21942 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure CI passes
Test plan
bazel build //docker-images/syntax-highlighter:image --config=darwin-docker