This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Fix pnpm format:changed
#53404
Merged
Fix pnpm format:changed
#53404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhchabran
approved these changes
Jun 13, 2023
camdencheek
commented
Jun 13, 2023
| @@ -12,7 +12,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "format": "prettier '**/{*.{js?(on),ts?(x),graphql,md,scss},.*.js?(on)}' --list-different --config prettier.config.js --write", | |||
| "format:changed": "prettier $(git diff --diff-filter=d --name-only origin/main... && git ls-files --other --modified --exclude-standard | grep -E '\\.(js|json|ts|tsx|graphql|md|scss)$' | xargs) --write --list-different --config prettier.config.js", | |||
| "format:changed": "prettier $( { git diff --diff-filter=d --name-only origin/main... && git ls-files --other --modified --exclude-standard ; } | grep -E '\\.(js|json|ts|tsx|graphql|md|scss)$' | xargs) --write --list-different --config prettier.config.js", | |||
There was a problem hiding this comment.
Previously, grep would only apply to the second git command here, so the output of git diff would spit out files that prettier could not handle. This just wraps the two git commands in a block so their output will both be filtered by the grep command.
sashaostrikov
approved these changes
Jun 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sequence of events:
pnpm formatpackage.jsonand see that it already existsTest plan
Ran
pnpm format:changedand it works on my local branch now.