Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

dx: update percy-cli #51133

Merged
merged 1 commit into from
Apr 26, 2023
Merged

dx: update percy-cli #51133

merged 1 commit into from
Apr 26, 2023

Conversation

valerybugakov
Copy link
Member

@valerybugakov valerybugakov commented Apr 26, 2023

Updated percy-cli to the latest version.

Test plan

CI

@valerybugakov valerybugakov added the dx Issues and PRs related to developer experience concerns label Apr 26, 2023
@valerybugakov valerybugakov self-assigned this Apr 26, 2023
@cla-bot cla-bot bot added the cla-signed label Apr 26, 2023
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label Apr 26, 2023
@valerybugakov valerybugakov marked this pull request as ready for review April 26, 2023 03:31
@valerybugakov valerybugakov requested a review from a team April 26, 2023 03:31
Copy link
Contributor

@sashaostrikov sashaostrikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Asked one question

@@ -28513,7 +28507,6 @@ packages:
- '@swc/core'
- esbuild
- uglify-js
dev: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-checking: is this an intended change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks correct because webpack is a dev dependency. It might be related to some other pnpm-lock file changes we made recently.

@valerybugakov valerybugakov merged commit ef49fee into main Apr 26, 2023
@valerybugakov valerybugakov deleted the vb/percy-cli-update branch April 26, 2023 05:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dx Issues and PRs related to developer experience concerns team/code-exploration Issues owned by the Code Exploration team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants