Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Fix local dev server streaming resources (to unblock streaming search and Cody streaming) #50725

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

philipp-spiess
Copy link
Contributor

This PR fixes the local dev server for both the webpack and esbuild setups to no longer buffer requests to streaming endpoints.

This fixes streaming search and Cody in the web-standalone run options.

Test plan

Screen.Recording.2023-04-17.at.16.25.02.mov

@philipp-spiess philipp-spiess requested review from valerybugakov, umpox and a team April 17, 2023 14:31
@philipp-spiess philipp-spiess self-assigned this Apr 17, 2023
@cla-bot cla-bot bot added the cla-signed label Apr 17, 2023
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label Apr 17, 2023
@philipp-spiess philipp-spiess changed the title Do not recompress cody endpoint for local dev proxy Fix local dev server streaming resources (to unblock streaming search and cody streaming) Apr 17, 2023
@philipp-spiess philipp-spiess changed the title Fix local dev server streaming resources (to unblock streaming search and cody streaming) Fix local dev server streaming resources (to unblock streaming search and Cody streaming) Apr 17, 2023
@sg-e2e-regression-test-bob

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (+0.04 kb) 0.00% (+0.28 kb) 0.00% (+0.25 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 6d884b7 and 1d4e0c5 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@philipp-spiess philipp-spiess merged commit a53643b into main Apr 17, 2023
@philipp-spiess philipp-spiess deleted the ps/fix-local-cody-streaming branch April 17, 2023 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed team/code-exploration Issues owned by the Code Exploration team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants