-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
VS Code calls these "inline suggestions", and it's a different command ( |
Making this a draft PR while I port over to the chatgpt turbo now that openai is sunsetting codex |
cae5889
to
6b8b72b
Compare
I am very eager to get this merged and start trying it out |
jinx...commented at the same time, I guess we are both eager :) |
ec38fd4
to
7c0fbf4
Compare
@abeatrix can I get a re-review? |
7c0fbf4
to
6d1f531
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me + the auto completion works for me.
I played around CompletionItemProvider and InlineCompletionItemProvider and thought CompletionItemProvider was nicer initially since it didn't require users to trigger manually, but I do see the appeal of having suggestions display in-line 🤔
Update: scratch that, I think calling it manually is better
if (!choice.message?.content) { | ||
continue | ||
} | ||
inlineCompletions.push(new vscode.InlineCompletionItem(completionPrefix + choice.message.content)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about replacing InlineCompletionItem
with CompletionItem
?
The InlineCompletionItem works, but require users to trigger it manually with workspace command:
I tried replacing InlineCompletionItem
with CompletionItem
which allows suggestion to trigger on keypresses. Here I've configured it to trigger on space, tab, and enter keys:
@beyang when you gonna merge this? |
6d1f531
to
ac2c441
Compare
Enable using this setting:
Inline suggestion
Multiple suggestions in a separate buffer
Implementation
Follow-up work / todo
App preview:
Check out the client app preview documentation to learn more.
Test plan
Cody is still experimental. Tested locally.