Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Manually trap web-ext return code to avoid throwing when uploading to the Mozilla store #44380

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

philipp-spiess
Copy link
Contributor

@philipp-spiess philipp-spiess commented Nov 14, 2022

Currently, whenever we publish a new browser extension version to the Mozilla store, the script fails even though the upload succeeds. This causes noise in our CI system and confusion amongst engineers.

This "fixes" this based on best practices from this thread (we can't adopt the web-ext-submit script but this is applying a similar pattern directly in our bash script).

Test plan

Exit propagation works:
Screenshot 2022-11-14 at 20 14 11

The rest we have to try and see the next time we publish an extension?

App preview:

Check out the client app preview documentation to learn more.

@cla-bot cla-bot bot added the cla-signed label Nov 14, 2022
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label Nov 14, 2022
@philipp-spiess philipp-spiess self-assigned this Nov 14, 2022
@philipp-spiess philipp-spiess requested review from marekweb and a team November 14, 2022 19:16
@philipp-spiess philipp-spiess marked this pull request as ready for review November 14, 2022 19:16
@sg-e2e-regression-test-bob

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) 0.00% (0.00 kb) 0.00% (0.00 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 0cd8a3f and 433da06 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@philipp-spiess philipp-spiess merged commit 0e68f41 into main Nov 15, 2022
@philipp-spiess philipp-spiess deleted the ps/fix-ff-sign branch November 15, 2022 09:48
@fregante
Copy link

we can't adopt the web-ext-submit script

How come?

@philipp-spiess
Copy link
Contributor Author

@fregante I’m afraid I don't remember 😞 I should've added more context, my bad.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed team/code-exploration Issues owned by the Code Exploration team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants