This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Manually trap web-ext return code to avoid throwing when uploading to the Mozilla store #44380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, whenever we publish a new browser extension version to the Mozilla store, the script fails even though the upload succeeds. This causes noise in our CI system and confusion amongst engineers.
This "fixes" this based on best practices from this thread (we can't adopt the
web-ext-submit
script but this is applying a similar pattern directly in our bash script).Test plan
Exit propagation works:
The rest we have to try and see the next time we publish an extension?
App preview:
Check out the client app preview documentation to learn more.