fix and test loading ESM providers in VS Code #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sqs
commented
May 18, 2024
sqs
commented
- Use a hacky pure-JS converter from ESM to CommonJS instead of the esbuild approach, which was very heavyweight due to its use of wasm and was hard for consumers of @openctx/vscode-lib to use.
- Refactor how clients can override imports.
sqs
force-pushed
the
sqs/file-provider
branch
4 times, most recently
from
bac69dc to
4803a17
Compare
- Use a hacky pure-JS converter from ESM to CommonJS instead of the esbuild approach, which was very heavyweight due to its use of wasm and was hard for consumers of @openctx/vscode-lib to use. - Refactor how clients can override imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.