remove AsyncGenerator API, improve Observable API #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Async generators turned out to be too tricky to work with in the Cody repo, so just remove that experimental async generator API. And make the Observable API accept interop observables so we can use `observable-fns` instead of full-blown `rxjs`.
sqs
force-pushed
the
sqs/observable-api
branch
from
b9edb06 to
9ec42fb
Compare
bevzzz
pushed a commit
to bevzzz/openctx
that referenced
this pull request
Dec 12, 2024
Async generators turned out to be too tricky to work with in the Cody repo, so just remove that experimental async generator API. And make the Observable API accept interop observables so we can use `observable-fns` instead of full-blown `rxjs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async generators turned out to be too tricky to work with in the Cody repo, so just remove that experimental async generator API. And make the Observable API accept interop observables so we can use
observable-fnsinstead of full-blownrxjs.