disable windows/macOS e2e tests on main, shard ubuntu tests #7031
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The e2e tests pass fairly reliably on PRs where we break them up into 5 separate runs. But on main we run all the e2e tests in a single go. This appears to be causing test failures after 9min due to cancellation (and in general, it is flakier because it just takes 1 e2e test flake). The Windows and macOS full e2e tests have been failing recently, so they are disabled. It would be good to reenable them. But now the Ubuntu e2e tests should pass on main.
umpox
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e tests pass fairly reliably on PRs where we break them up into 5 separate runs. But on main we run all the e2e tests in a single go. This appears to be causing test failures after 9min due to cancellation (and in general, it is flakier because it just takes 1 e2e test flake).
The Windows and macOS full e2e tests have been failing recently, so they are disabled. It would be good to reenable them. But now the Ubuntu e2e tests should pass on main.
Test plan
n/a