chore: Remove hard-coded 'deep-cody' and replace with constant #6958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bugged me while reading and to warm up to the codebase, I decided to replace the hardcoded strings with the reference. Can't do it in `lib/shared`, but in `vscode`.
abeatrix
approved these changes
Feb 5, 2025
|
@mrnugget first PR? |
No, had another one yesterday! |
sqs
reviewed
Feb 5, 2025
vscode/webviews/components/modelSelectField/ModelSelectField.story.tsx
Outdated
Show resolved
Hide resolved
|
@mrnugget running |
|
Went ahead and merged even though unit tests on Windows failed. Looks like they're not run on |
julialeex
pushed a commit
that referenced
this pull request
Feb 7, 2025
…constant (#7019) This bugged me while reading and to warm up to the codebase, I decided to replace the hardcoded strings with the reference. Can't do it in `lib/shared`, but in `vscode`. ## Test plan - Run Cody and see that agentic chat works. <br> Backport 386c0b6 from #6958 Co-authored-by: Thorsten Ball <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugged me while reading and to warm up to the codebase, I decided to replace the hardcoded strings with the reference. Can't do it in
lib/shared, but invscode.Test plan