Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in cody bench #5849

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix bug in cody bench #5849

merged 1 commit into from
Oct 9, 2024

Conversation

beyang
Copy link
Member

@beyang beyang commented Oct 8, 2024

Call setClientCapabilitiesFromConfiguration(getConfiguration()) in the right place so cody internal bench doesn't throw an exception.

Test plan

Only affects cody internal bench

@beyang beyang requested review from olafurpg and a team October 8, 2024 23:21
@beyang beyang enabled auto-merge (squash) October 8, 2024 23:21
olafurpg
olafurpg approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM It is a bit strange to me that this is needed because the command-bench.ts file runs on a Node.js process that orchestrates Cody agent processes, this process doesn't actually activate the VSC extension. Either way, this is a low-risk change

@beyang beyang merged commit e1cac97 into main Oct 9, 2024
18 of 19 checks passed
@beyang beyang deleted the bl/fix-bug-bench branch October 9, 2024 17:06
PriNova pushed a commit to PriNova/cody that referenced this pull request Oct 11, 2024
@beyang @PriNova
fix bug in cody bench (sourcegraph#5849)
198e655 
Call `setClientCapabilitiesFromConfiguration(getConfiguration())` in the
right place so `cody internal bench` doesn't throw an exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

@camdencheek camdencheek camdencheek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beyang @olafurpg @camdencheek