Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: restructure commands (breaking change!) #4792

Merged
merged 7 commits into from
Jul 5, 2024

Conversation

olafurpg
Copy link
Member

@olafurpg olafurpg commented Jul 5, 2024

This PR batches several breaking changes to the Cody cli tool. See individual commit messages for details:

commit 12d7bda (HEAD -> olafurpg-cody-2752-remove-automatic-jsonrpc-command, olafurpg/olafurpg-cody-2752-rem
ove-automatic-jsonrpc-command)
Author: Olafur Geirsson [email protected]
Date: Fri Jul 5 10:47:02 2024 +0200

Minor improvements to `cody --help`

Fixes CODY-2777

- Display `cody` in --help message
- Show `auth` and `chat` subcommands at the top
- Display correct version number
- Move `cody cody-bench` to `cody internal bench`

commit 6c3506b
Author: Olafur Geirsson [email protected]
Date: Fri Jul 5 10:46:41 2024 +0200

Update changelog and outdated CLI docs

Fixes CODY-2778

commit 033585e
Author: Olafur Geirsson [email protected]
Date: Fri Jul 5 10:26:57 2024 +0200

CLI: restructure commands

Fixes CODY-2634

- `cody jsonrpc` is now `cody api jsonrpc-stdio`.
- `cody server` is now `cody api jsonrpc-websocket`.
- Files consistently use the `command-NAME.ts` name convention making it
  easier to find them in the fuzzy finder.

commit e187aab
Author: Olafur Geirsson [email protected]
Date: Fri Jul 5 10:20:11 2024 +0200

CLI: remove automatic `jsonrpc` command

Fixes CODY-2752

Previously, running `cody-agent` started the `cody-agent jsonrpc`
subcommand. This was done for historical reasons that are no longer
important. This is a breaking change and means that IDE clients will
need to explicitly mention the `api jsonrpc` subcommand now.

Test plan

Green CI.

olafurpg added 5 commits July 5, 2024 10:20
Fixes CODY-2752

Previously, running `cody-agent` started the `cody-agent jsonrpc`
subcommand. This was done for historical reasons that are no longer
important. This is a breaking change and means that IDE clients will
need to explicitly mention the `api jsonrpc` subcommand now.
Fixes CODY-2634

- `cody jsonrpc` is now `cody api jsonrpc-stdio`.
- `cody server` is now `cody api jsonrpc-websocket`.
- Files consistently use the `command-NAME.ts` name convention making it
  easier to find them in the fuzzy finder.
Fixes CODY-2777

- Display `cody` in --help message
- Show `auth` and `chat` subcommands at the top
- Display correct version number
- Move `cody cody-bench` to `cody internal bench`
@olafurpg olafurpg requested a review from a team July 5, 2024 09:08
Copy link

github-actions bot commented Jul 5, 2024

‼️ Hey @sourcegraph/cody-security, please review this PR carefully as it introduces the usage of an unsafe_ function or abuses PromptString.

Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olafurpg olafurpg merged commit aa6e4fe into main Jul 5, 2024
19 checks passed
@olafurpg olafurpg deleted the olafurpg-cody-2752-remove-automatic-jsonrpc-command branch July 5, 2024 11:07
olafurpg added a commit to sourcegraph/eclipse that referenced this pull request Jul 5, 2024
This required changing the CLI invocation to mirror the new command
structure from the PR sourcegraph/cody#4792
olafurpg added a commit to sourcegraph/eclipse that referenced this pull request Jul 5, 2024
This required changing the CLI invocation to mirror the new command
structure from the PR sourcegraph/cody#4792
olafurpg added a commit to sourcegraph/eclipse that referenced this pull request Jul 5, 2024
This required changing the CLI invocation to mirror the new command
structure from the PR sourcegraph/cody#4792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants