This repository has been archived by the owner on Nov 25, 2021. It is now read-only.
fix: exclude end position in findElementWithOffset #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 85.86% 85.86%
=======================================
Files 14 14
Lines 651 651
Branches 174 174
=======================================
Hits 559 559
Misses 92 92
Continue to review full report at Codecov.
|
efritz
approved these changes
Apr 9, 2021
felixfbecker
approved these changes
Apr 9, 2021
|
🎉 This PR is included in version 7.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error discussed in #360, introduced by #331.
Treat end position of a range as exclusive. Previously, we would erroneously highlight DOM nodes that started at hovered nodes' specified end positions.