CSEC: Use method descriptors after overloading #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets an improvement to the CSEC machine. It replaces closures with human-readable method descriptors after method overloading to better reflect Java's native behaviour.
The current method descriptor format used for each kind of method is:
<return type> <identifier>(<parameter types>)
<return type> <class>::<identifier>(<parameter types>)
<class>(<parameter types>)
This implements another type of stash item
MethodDescriptor
that holds information necessary for overriding, including the return type, identifier, parameter types, and also a human-readable method descriptor that can be displayed.MethodDescriptor
: need to modifyresOverride
to pull the relevant items directly from theMethodDescriptor
.