Image ALT tags, conversion options, footer URLs and silent DOM. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Html2Text::convert() can now accept an array as a second parameter, which allows passing in various options for the conversion process. This array is passed through to iterateOverNode(). Added an option (OPT_FOOTER_URLS) for relocating link URLs to the end of the document, replacing them with a numerical placeholder in the text. Makes the document much easier to read if there are a lot of long URLs in the HTML.
Make DOMDocument silent (not throwing any errors or warnings)
ravisorg
changed the title
| @@ -30,21 +47,38 @@ class Html2Text { | |||
| * </ul> | |||
| * | |||
| * @param string html the input HTML | |||
| * @param array An array of options of the Html2Text::OPT_* variety | |||
There was a problem hiding this comment.
Should start with @param array options An array ... instead. Variable name is missing.
|
@ravisorg I've opened a PR to your repo which addresses some of the above notes. |
|
When you approve that PR, I think those commits will be automatically available here as well. |
|
In 0.3.0 images will now display as alt tags, and links will display alt/title tags of the |
|
Silent errors are now supported in #43 |
|
This PR has become out of date - if you would still like to contribute this change to this project, could you look at pulling the latest source and re-submitting the PR? Thank you! |
|
I will be adding conversion options in 1.0: #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.