Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use only FoundationEssentials #628

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

t089
Copy link

@t089 t089 commented Dec 12, 2024

Copies over some bits and pieces from FoundationEssentials itself. Just wanted to make it build.

t089 added 4 commits December 10, 2024 15:20
# Conflicts:
#	Sources/SotoCore/Middleware/Middleware/S3Middleware.swift
#	Sources/SotoSignerV4/signer.swift
#	scripts/generate-errors.swift
#	scripts/generate-region-test.swift
#	scripts/generate-region.swift
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 63.57616% with 55 lines in your changes missing coverage. Please review.

Project coverage is 79.71%. Comparing base (445ce27) to head (37a0b92).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
Sources/SotoUtils/String+Utils.swift 62.32% 55 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
- Coverage   80.54%   79.71%   -0.83%     
==========================================
  Files          78       79       +1     
  Lines        6575     6819     +244     
==========================================
+ Hits         5296     5436     +140     
- Misses       1279     1383     +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant