Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nvidia] Add New Plugin #1697

Closed
wants to merge 1 commit into from

Conversation

TurboTurtle
Copy link
Member

Adds a new plugin for obtaining GPU information from nvidia cards with
the nvidia-smi utility.

Fixes: #1685

Signed-off-by: Jake Hunsaker [email protected]


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?

@TurboTurtle
Copy link
Member Author

TurboTurtle commented Jun 7, 2019

This is based off the requests in #1685, but I do not have access to a system to test this on.

@dfeddema - can you test this branch and see if it gives the information you're looking for? I combined the fields from items 4-7.

I also made a guess that having non-csv output would be helpful for at-a-glance review by humans, so I added both non-csv and csv output. Please let me know if that's not desired.

@dfeddema
Copy link

dfeddema commented Jun 7, 2019 via email

@TurboTurtle
Copy link
Member Author

@dfeddema - just checking in, were you able to test this?

@dfeddema
Copy link

dfeddema commented Jul 3, 2019 via email

@TurboTurtle
Copy link
Member Author

TurboTurtle commented Jul 3, 2019

Thanks for testing!

Yeah, I added the one without a --format on a guess. Is there a value for --format that is more human readable than csv output? If not I can also just drop that entirely and the plugin will only collect the csv formatted output.

@TurboTurtle
Copy link
Member Author

I've dropped the extra query without the format switch. Based on feedback above, this should be good to go now.

@BryanQuigley
Copy link
Contributor

Mind adding Ubuntu and Debian plugins to this as well? I just tested this and it works great. Thanks!

Adds a new plugin for obtaining GPU information from nvidia cards with
the nvidia-smi utility.

Fixes: sosreport#1685

Signed-off-by: Jake Hunsaker <[email protected]>
@TurboTurtle
Copy link
Member Author

Done.

Copy link
Contributor

@BryanQuigley BryanQuigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested on Single GPU system on Ubuntu and works great.

@bmr-cymru bmr-cymru closed this in 4a8e0f8 Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nvidia-smi info to SOS reports for systems running AI workloads on Nvidia GPUs
4 participants