Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godep workspace -> vendor/ #141

Closed
wants to merge 1 commit into from
Closed

Godep workspace -> vendor/ #141

wants to merge 1 commit into from

Conversation

agalitsyn
Copy link

  • Upgrade vendoring scheme to use standard import paths and GO15VENDOREXPERIMENT

@sgotti
Copy link
Member

sgotti commented Jul 13, 2016

@agalitsyn Some months ago I open but never merged #131. I opted for glide + glide-vc since it looked like a cleaner way to handle dependencies and pin their versions without messing with the GOPATH or creating a clean GOPATH with the wanted version for every dependency. Now the same idea is used in other projects like CoreOS rkt and other.

What're your thoughts on this? Will you mind to rebase your work starting with #131?

@agalitsyn
Copy link
Author

from my point of view there is no dramatic difference between glide and godeps, both do vendoring, so if you prefer glide we can close PR

@sgotti
Copy link
Member

sgotti commented Sep 9, 2016

@agalitsyn Thanks, I'll go ahead with glide and update #131 (also updating libkv as in #140).

@sgotti
Copy link
Member

sgotti commented Sep 13, 2016

Done in #131.

@sgotti sgotti closed this Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants