Improve batch swap transfer #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wer1st
reviewed
Sep 6, 2023
wer1st
approved these changes
Sep 13, 2023
rust-toolchain.toml
Outdated
| [toolchain] | ||
| channel = "nightly-2023-03-21" | ||
| targets = [ "wasm32-unknown-unknown" ] | ||
| profile = "default" |
Alexey-N-Chernyshov
approved these changes
Sep 13, 2023
| @@ -0,0 +1,4 @@ | |||
| [toolchain] | |||
There was a problem hiding this comment.
As I remember, there was a reason not to commit toolchain file. I could be wrong.
There was a problem hiding this comment.
Actually it doesn't build without it. And I think we can use it to ensure that correct Rust version is used by everyone. If we will have any problems with this solution we can remove this file
| @@ -0,0 +1,4 @@ | |||
| [toolchain] | |||
| channel = "nightly-2023-03-21" | |||
There was a problem hiding this comment.
We have the same version of Rust in docker and we can't update it before Substrate update because of problems with wasm
Co-authored-by: Alexey <[email protected]>
Alexey-N-Chernyshov
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.