Random xor-fee remint

pallets/kensetsu/src/lib.rs

@@ -285,13 +285,11 @@ pub mod pallet {
                 // known problem. The purpose of the code is not to protect from the attack but to
                 // make choosing of CDP to liquidate more 'fair' then incremental order.
                 let (randomness, _) = T::Randomness::random(&b"kensetsu"[..]);
-                match randomness {
-                    Some(randomness) => {
-                        match u32::decode(&mut randomness.as_ref()) {
-                            Ok(random_number) => {
-                                // Random bias by modulus operation is acceptable here
-                                let random_id = random_number as usize % unsafe_cdp_ids.len();
-                                unsafe_cdp_ids
+                match u32::decode(&mut randomness.as_ref()) {
+                    Ok(random_number) => {
+                        // Random bias by modulus operation is acceptable here
+                        let random_id = random_number as usize % unsafe_cdp_ids.len();
+                        unsafe_cdp_ids
                                     .get(random_id)
                                     .map_or_else(
                                         || {
@@ -311,14 +309,9 @@ pub mod pallet {
                                             );
                                         }
                                     });
-                            }
-                            Err(error) => {
-                                warn!("Failed to get randomness during liquidation: {}", error);
-                            }
-                        }
                     }
-                    None => {
-                        warn!("No randomness provided.");
+                    Err(error) => {
+                        warn!("Failed to get randomness during liquidation: {}", error);
                     }
                 }
             }
@@ -333,7 +326,7 @@ pub mod pallet {
         + SendTransactionTypes<Call<Self>>
     {
         type RuntimeEvent: From<Event<Self>> + IsType<<Self as frame_system::Config>::RuntimeEvent>;
-        type Randomness: Randomness<Option<Self::Hash>, Self::BlockNumber>;
+        type Randomness: Randomness<Self::Hash, Self::BlockNumber>;
         type AssetInfoProvider: AssetInfoProvider<
             AssetIdOf<Self>,
             Self::AccountId,

pallets/kensetsu/src/mock.rs

@@ -71,8 +71,8 @@ type UncheckedExtrinsic = frame_system::mocking::MockUncheckedExtrinsic<TestRunt
 
 pub struct MockRandomness;
 
-impl Randomness<Option<Hash>, BlockNumber> for MockRandomness {
-    fn random(_subject: &[u8]) -> (Option<Hash>, BlockNumber) {
+impl Randomness<Hash, BlockNumber> for MockRandomness {
+    fn random(_subject: &[u8]) -> (Hash, BlockNumber) {
         unimplemented!()
     }
 }

pallets/xor-fee/src/benchmarking.rs

@@ -108,5 +108,12 @@ benchmarks! {
         }
     }
 
+    set_random_remint_period {
+        let new_period = 500_u32;
+    }: _(RawOrigin::Root, new_period)
+    verify {
+        assert_eq!(<RemintPeriod<T>>::get(), new_period);
+    }
+
     impl_benchmark_test_suite!(Pallet, mock::ExtBuilder::build(), mock::Runtime);
 }