This repository has been archived by the owner on Apr 27, 2023. It is now read-only.
[feature/mission-detail] 미션 상세 화면 제작 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l2hyunwoo
force-pushed
the
feature/mission-detail
branch
from
681683b to
0d5210c
Compare
jinsu4755
approved these changes
Dec 13, 2022
| @DrawableRes icon: Int, | ||
| maxStars: Int = DEFAULT_MAX, | ||
| stars: Int, | ||
| gapSize: Int = 10, |
There was a problem hiding this comment.
해당 부분에서 결국 Dp 단위의 사이즈를 받아야 하는 것이라면, 받을 수 있는 인자를 Dp 타입으로 고정하는 것은 어떨까요?
Component 로 사용된다면, 대부분의 경우 dp 를 넣기 때문에 추후 인수인계를 위해서도 여기에서만 int 로 들어간다 라기보다 dp 를 받을 수 있도록 통일하면 좋을 것 같다는 생각이 들었습니다 :)
Comment on lines
31
to
32
| fun getIdFrom(type: ToolbarIconType) = values().find { it.name == type.name }?.resId | ||
| ?: throw IllegalArgumentException("There's no icon in this class. Icon: ${type.name}") |
There was a problem hiding this comment.
Enum 타입을 받아서 Enum 타입 들 중에서 해당하는 Enum의 id 를 뽑아오는 모습이 개인적으로 부자연스럽다는 생각이 듭니다.
ToolbarIconType.WRITE.resId 와 차이점이 있을까요?
There was a problem hiding this comment.
아하 그렇군요! 이 부분은 제가 따로 로직 만들어서 수정하도록 하겠습니다.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference