Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix target KPI usage in tutorials #992

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

ofirgo
Copy link
Collaborator

@ofirgo ofirgo commented Mar 12, 2024

Pull Request Description:

We moved the target_kpi argument from the facades to the mixed precision config.
This PR fixes this in all tutorials and quick start.
In addition, we adding an option to set the target KPI after initializing the core config with the mp config inside it.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@ofirgo ofirgo merged commit 594ce9d into sony:main Mar 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants