Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MP batch axis #991

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix MP batch axis #991

merged 1 commit into from
Mar 12, 2024

Conversation

eladc-git
Copy link
Collaborator

@eladc-git eladc-git commented Mar 12, 2024

Pull Request Description:

This PR removes the batch list for MP calculation and use the internal batch flag in the error function. Special care for KL divergence error function.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@eladc-git eladc-git requested a review from ofirgo March 12, 2024 12:25
@eladc-git eladc-git merged commit a5b5365 into sony:main Mar 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants