Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old per-channel configuration from QuantizationConfig #919

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

reuvenperetz
Copy link
Collaborator

Pull Request Description:

Old parameter that is used from TPC currently, is removed in this PR.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

Old parameter that is used from TPC currently, is removed in this PR.
@reuvenperetz reuvenperetz requested a review from ofirgo January 22, 2024 16:09
Copy link
Collaborator

@ofirgo ofirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remember to update this change in the release notes since it can affect users that passing configs
  2. Check if this affects tutorials

@reuvenperetz reuvenperetz merged commit b62ed4e into sony:main Jan 31, 2024
24 checks passed
@reuvenperetz reuvenperetz deleted the fix-qc-per-channel branch January 31, 2024 13:29
lior-dikstein pushed a commit that referenced this pull request Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants