Fix bug in FolderImageLoader #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FolderImageLoader chooses a list of possible integers among all integers of indices of the images in the folder that we load. In FolderImageLoader we choose the indices of the images to sample every time, from all possible indices of the images in the folder. The selection was between 0 to num_of_images-1, so when the folder contains only one image, we tried to choose indices from an empty group. The indices now are selected from 0 to num_of_images, so the bug is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FolderImageLoader chooses a list of possible integers
among all integers of indices of the images in the folder
that we load.
In FolderImageLoader we choose the indices of the images
to sample every time, from all possible indices of the images in
the folder.
The selection was between 0 to num_of_images-1, so when the folder
contains only one image, we tried to choose indices from
an empty group.
The indices now are selected from 0 to num_of_images, so the bug
is fixed.