Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that caused ViT models to raise errors. #1374

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

lior-dikstein
Copy link
Collaborator

@lior-dikstein lior-dikstein commented Mar 4, 2025

Pull Request Description:

Fixed bug in ScaledDotProductDecomposition substitution regarding how output_shapes of nodes are calculated.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

…dition, modified number of astar iterations from 500 to 1000 in compute_graph_max_cut to ensure ViT models function correctly
@lior-dikstein lior-dikstein merged commit 6ed7786 into main Mar 5, 2025
42 checks passed
@lior-dikstein lior-dikstein deleted the fix-vit-bug branch March 5, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants