Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bops calculation #1369

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Fix bops calculation #1369

wants to merge 15 commits into from

Conversation

irenaby
Copy link
Collaborator

@irenaby irenaby commented Feb 26, 2025

Pull Request Description:

Support for bops computation on virtual nodes in RU calculator.
Updated virtual graph substitutions to fix activation & weights RU calculation on virtual graph.
Use RU calculator for bops in mixed precision search.
Added integration tests for RU calculator (framework -> graph preparation -> RU calculator, original vs virtual graph).
Added verification that target RU is satisfied by final RU in MP tests.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@irenaby irenaby marked this pull request as ready for review February 26, 2025 17:01
@irenaby irenaby requested review from elad-c and ofirgo February 26, 2025 17:02
@ofirgo
Copy link
Collaborator

ofirgo commented Feb 27, 2025

@irenaby
I don't remember from all we discussed whether this PR changes any behavior that is not BOPs only related (activation/weights memory estimation, any RU computation in MP or RU data besides BOPs).
If there is something like that, please specify this in the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants