Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with absolute links of images #1357

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

reuvenperetz
Copy link
Collaborator

Pull Request Description:

Images in pypi are not displayed due to usage of relative paths of the images. This PR fixes this issue.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

Images in pypi are not displayed due to usage of relative paths of the images. This PR fixes this issue.
@ofirgo ofirgo merged commit b151d9d into main Feb 13, 2025
42 checks passed
@reuvenperetz reuvenperetz deleted the reuvenperetz-patch-2 branch February 13, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants