Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yolov8n Instance segmentation tutorial #1084

Merged
merged 4 commits into from
Jun 3, 2024
Merged

yolov8n Instance segmentation tutorial #1084

merged 4 commits into from
Jun 3, 2024

Conversation

samuel-wj-chapman
Copy link
Contributor

@samuel-wj-chapman samuel-wj-chapman commented May 22, 2024 •
edited
Loading

Pull Request Description:

Notebook utilities required for instance segmentation quantisation tutorial.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@samuel-wj-chapman
Copy link
Contributor Author

All relevant changes should be added

Idan-BenAmi
Idan-BenAmi reviewed May 30, 2024
View reviewed changes
tutorials/mct_model_garden/models_pytorch/yolov8/yolov8.py
return y_bb, y_cls, mc, p


class ModelPyTorch(nn.Module, PyTorchModelHubMixin):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the renaming of the module will now work with the detection model.. we need to check

@samuel-wj-chapman
Copy link
Contributor Author

samuel-wj-chapman commented May 30, 2024 •
edited
Loading

broken link due to pre-emptive link.

Broken link: https://github.com/sony/model_optimization/blob/main/tutorials/notebooks/pytorch/ptq/pytorch_yolov8n_seg_for_imx500.ipynb in /home/runner/work/model_optimization/model_optimization/tutorials/notebooks/imx500_notebooks/pytorch/pytorch_yolov8n_seg_for_imx500.ipynb

@samuel-wj-chapman samuel-wj-chapman merged commit 59babd9 into sony:main Jun 3, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Idan-BenAmi Idan-BenAmi Idan-BenAmi approved these changes

Assignees
No one assigned
Labels
auto:tutorials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuel-wj-chapman @Idan-BenAmi