Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix torchvision import #1064

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix torchvision import #1064

merged 2 commits into from
May 9, 2024

Conversation

reuvenperetz
Copy link
Collaborator

Pull Request Description:

Fix an issue in importing torchvision during data generation init.
If torch was found and torchvision wasn't - an error was raised even when data generation wasn't used.
This PR fixes this, by checking it torchvision was also found.

In addition, after publishing the nightly package, it's tested that an import can be done after install tf and torch.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@reuvenperetz reuvenperetz merged commit 2376ed4 into main May 9, 2024
26 of 27 checks passed
@reuvenperetz reuvenperetz deleted the fix-torchvision-import branch May 9, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants