Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1058 #1060

Merged
merged 4 commits into from
May 9, 2024
Merged

Fix issue 1058 #1060

merged 4 commits into from
May 9, 2024

Conversation

reuvenperetz
Copy link
Collaborator

Pull Request Description:

Fix an issue that imports onnx in the exporter during init if torch was found:

  • In fakely_quant_onnx_pytorch_exporter.py, import onnx-related modules only if onnx was found. Add "dummy" FakelyQuantONNXPyTorchExporter to raise an error if it was used without Onnx installed.
  • Move DEFAULT_ONNX_OPSET_VERSION to pytorch_export_facade.py to use it only there since it's in the pytorch_export_facade api.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@reuvenperetz reuvenperetz merged commit c022f09 into main May 9, 2024
26 of 27 checks passed
@reuvenperetz reuvenperetz deleted the fix-issue-1058 branch May 9, 2024 09:36
@reuvenperetz reuvenperetz linked an issue May 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requirements.txt is missing the onnx module
2 participants