-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag to indicate whether to run mixed precision according to resource utilization provided by user. #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/common_tests/helpers/generate_test_tp_model.py
…ccommodate for the changes in running mixed precision.
ofirgo
requested changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cosmetic comments.
In addition:
- Please add a dedicated test for the new feature (define a setup with TPC that would run mixed precision before the new feature, and verify that it didn't run mixed precision). I would replicate this test for each of the available resource utilization types.
- Please update the release notes draft.
- Also add a description to the PR with an explanation about the feature (and include it in the commit message when you merge it).
..._toolkit/core/common/mixed_precision/resource_utilization_tools/resource_utilization_data.py
Outdated
Show resolved
Hide resolved
..._toolkit/core/common/mixed_precision/resource_utilization_tools/resource_utilization_data.py
Outdated
Show resolved
Hide resolved
..._toolkit/core/common/mixed_precision/resource_utilization_tools/resource_utilization_data.py
Outdated
Show resolved
Hide resolved
..._toolkit/core/common/mixed_precision/resource_utilization_tools/resource_utilization_data.py
Outdated
Show resolved
Hide resolved
..._toolkit/core/common/mixed_precision/resource_utilization_tools/resource_utilization_data.py
Outdated
Show resolved
Hide resolved
..._toolkit/core/common/mixed_precision/resource_utilization_tools/resource_utilization_data.py
Outdated
Show resolved
Hide resolved
..._toolkit/core/common/mixed_precision/resource_utilization_tools/resource_utilization_data.py
Outdated
Show resolved
Hide resolved
..._toolkit/core/common/mixed_precision/resource_utilization_tools/resource_utilization_data.py
Show resolved
Hide resolved
tests/keras_tests/feature_networks_tests/feature_networks/weights_mixed_precision_tests.py
Outdated
Show resolved
Hide resolved
tests/pytorch_tests/model_tests/feature_models/mixed_precision_activation_test.py
Outdated
Show resolved
Hide resolved
ofirgo
requested changes
May 2, 2024
..._toolkit/core/common/mixed_precision/resource_utilization_tools/resource_utilization_data.py
Outdated
Show resolved
Hide resolved
..._toolkit/core/common/mixed_precision/resource_utilization_tools/resource_utilization_data.py
Outdated
Show resolved
Hide resolved
ofirgo
reviewed
May 5, 2024
@@ -0,0 +1,80 @@ | |||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing license
ofirgo
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
Checklist before requesting a review: