Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Const quantization #1045

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Const quantization #1045

merged 6 commits into from
Apr 18, 2024

Conversation

elad-c
Copy link
Collaborator

@elad-c elad-c commented Apr 17, 2024 •
edited
Loading

Pull Request Description:

This PR enables quantizing constants in the model. Constants inputs to add, sub, mul & div will be quantized when using the IMX500.v2 TPC.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@elad-c elad-c requested review from ofirgo and reuvenperetz April 17, 2024 10:21
ofirgo
ofirgo reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@ofirgo ofirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't go through everything, but some questions/notes in the meantime

model_compression_toolkit/exporter/model_wrapper/fw_agnostic/get_inferable_quantizers.py Outdated Show resolved Hide resolved
model_compression_toolkit/core/common/graph/functional_node.py Show resolved Hide resolved
model_compression_toolkit/core/common/quantization/node_quantization_config.py Show resolved Hide resolved
...ression_toolkit/core/common/quantization/quantization_params_generation/lut_kmeans_params.py Show resolved Hide resolved
model_compression_toolkit/core/common/similarity_analyzer.py Show resolved Hide resolved
model_compression_toolkit/core/keras/reader/node_builder.py Show resolved Hide resolved
ofirgo
ofirgo requested changes Apr 18, 2024
View reviewed changes
model_compression_toolkit/target_platform_capabilities/tpc_models/imx500_tpc/v2/tp_model.py Show resolved Hide resolved
model_compression_toolkit/target_platform_capabilities/tpc_models/imx500_tpc/v2/tp_model.py Show resolved Hide resolved
model_compression_toolkit/target_platform_capabilities/tpc_models/imx500_tpc/v2/tp_model.py Show resolved Hide resolved
tests/keras_tests/feature_networks_tests/test_features_runner.py Show resolved Hide resolved
tests/pytorch_tests/model_tests/feature_models/const_quantization_test.py Outdated Show resolved Hide resolved
tests/keras_tests/feature_networks_tests/feature_networks/const_quantization_test.py Show resolved Hide resolved
tests/pytorch_tests/model_tests/feature_models/const_quantization_test.py Outdated Show resolved Hide resolved
@elad-c elad-c merged commit 64dacc0 into main Apr 18, 2024
27 checks passed
@elad-c elad-c deleted the const_quantization branch April 18, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofirgo ofirgo ofirgo approved these changes

@reuvenperetz reuvenperetz reuvenperetz approved these changes

Assignees
No one assigned
Labels
auto:core auto:exporter auto:target_platform_capabilities auto:tests enhancement New feature or request keras pr: major feature pytorch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elad-c @ofirgo @reuvenperetz